Closed Bug 1043695 Opened 6 years ago Closed 6 years ago

Clean up AppleDecoderModule

Categories

(Core :: Audio/Video, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(5 files)

Some follow-on patches for the Apple PlatformDecoderModule.
Depends on: 1043696
Blocks: 1043696
No longer depends on: 1043696
Assignee: nobody → giles
This is a series of small cleanup patches. Should be quick to review.
Attachment #8462222 - Flags: review?(cpearce)
Attachment #8462224 - Flags: review?(cpearce)
Suggestion from Anthony. Doesn't seem to make any difference, but more obviously not a typo than the previous code.
Attachment #8462227 - Flags: review?(cpearce)
Attachment #8462222 - Flags: review?(cpearce) → review+
Comment on attachment 8462224 [details] [diff] [review]
Part 2: Improve logging

Review of attachment 8462224 [details] [diff] [review]:
-----------------------------------------------------------------

You may want your own log module separate from the demuxer, as these logs will be very noisy when things are working properly.
Attachment #8462224 - Flags: review?(cpearce) → review+
Attachment #8462227 - Flags: review?(cpearce) → review+
I get a lot of dropped frames when I return them in the natural decode order. I assume the playback queue is rejecting the out-of-order frames. The Apple h.264 decoder needs to reorder the frames locally and return them in presentation order.

I've filed bug 1043710 to get the real reorder depth from the file, but in the meantime just using a depth of three corrects the problem for most files.
Attachment #8462237 - Flags: review?(cpearce)
Attachment #8462237 - Flags: review?(cpearce) → review+
Vim paste error in the copyright header.
Attachment #8463065 - Flags: review?(cpearce)
Attachment #8463065 - Flags: review?(cpearce) → review+
You need to log in before you can comment on or make changes to this bug.