Enable Apple PlatformDecoderModule for HTML5 video playback (MP4 playback on OSX)

RESOLVED FIXED in mozilla34

Status

()

Core
Audio/Video
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: rillian, Assigned: rillian)

Tracking

(Blocks: 1 bug, {dev-doc-needed})

Trunk
mozilla34
x86
Mac OS X
dev-doc-needed
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(relnote-firefox 35+)

Details

Attachments

(1 attachment, 3 obsolete attachments)

Quoth :cpearce: Now, try exposing the MP4Reader in normal <video> on MacOSX, and see what tests fail. We want H.264/AAC on MacOSX in <video> ASAP. :)
(Assignee)

Updated

3 years ago
No longer blocks: 1043695
Depends on: 941296, 1043695
(Assignee)

Updated

3 years ago
Assignee: nobody → giles
I bet we need bug 1039128 fixed before this is green. kft is working on a fix (drain isn't working properly).

Comment 2

3 years ago
How does this bug relate to Bug 1030516?
(Assignee)

Comment 3

3 years ago
It's probably a duplicate. Marking as blocking until ajones can clarify if he wanted something different there.
Blocks: 1030516
Flags: needinfo?(ajones)
Sounds like the same thing to me.
Flags: needinfo?(ajones)

Updated

3 years ago
Duplicate of this bug: 1030516

Updated

3 years ago
Summary: Enable Apple PlatformDecoderModule for HTML5 video playback → Enable Apple PlatformDecoderModule for HTML5 video playback (MP4 playback on OSX)

Updated

3 years ago
Blocks: 778617
(Assignee)

Comment 6

3 years ago
Created attachment 8472735 [details] [diff] [review]
Enable the fmp4 decoder unconditionally for <video>

Patch pushed to try for osx hosts. Passed on 10.6 as expected, since decoding doesn't work there. Got timeouts and errors on 10.8:

test_autoplay_contentEditable.html | Test timed out.
test_buffered.html | gizmo.mp4: Should be buffered in one range - got 0, expected 1
test_buffered.html | uncaught exception - IndexSizeError: Index or size is negative or greater than the allowed amount at http://mochi.test:8888/tests/content/media/test/test_buffered.html:32
test_bug448534.html | Test timed out.
test_bug465498.html | Test timed out.
test_bug495145.html | Test timed out.

Trying again now that the range calculation cleanup patches have landed.
(Assignee)

Comment 7

3 years ago
N.B. If we can get tests passing for osx before we get mp3-in-mp4 support landed, we want to enable this in nightly just for osx. Doing so unconditionally would be a regression on Windows.

Updated

3 years ago
Blocks: 799318
(Assignee)

Comment 8

3 years ago
Same errors with bug 1050060 fixed. https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=dd5e88f7a193
(Assignee)

Updated

3 years ago
Depends on: 1054023
(Assignee)

Updated

3 years ago
Depends on: 1054024
W(In reply to Ralph Giles (:rillian) from comment #7)
> N.B. If we can get tests passing for osx before we get mp3-in-mp4 support
> landed, we want to enable this in nightly just for osx. Doing so
> unconditionally would be a regression on Windows.

We can pref off mp3-in-mp4.
New try push since some demuxer changes have landed. https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=a86aa41e92e
(Assignee)

Updated

3 years ago
Depends on: 1056394
Depends on: 1043710
Created attachment 8476982 [details] [diff] [review]
Enable the fmp4 decoder for <video> on non-release osx builds

We expect to get this working on Mac before other platforms and want to enable it asap since it's the path to mp4 playback there. Adapt to patch to the conditional on the platform.
Attachment #8472735 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Depends on: 1057877
See Also: → bug 1057879
Comment on attachment 8476982 [details] [diff] [review]
Enable the fmp4 decoder for <video> on non-release osx builds

Review of attachment 8476982 [details] [diff] [review]:
-----------------------------------------------------------------

Asking for review now, since we're nearly ready to push the switch. Will land once I clean try pushes.
Attachment #8476982 - Flags: review?(cpearce)
Comment on attachment 8476982 [details] [diff] [review]
Enable the fmp4 decoder for <video> on non-release osx builds

Review of attachment 8476982 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/libpref/init/all.js
@@ +245,4 @@
>  #ifdef MOZ_FMP4
>  pref("media.fragmented-mp4.enabled", true);
>  pref("media.fragmented-mp4.ffmpeg.enabled", false);
> +#if defined(XP_MACOSX) && !defined(RELEASE_BUILD)

Remove the !defined(RELEASE_BUILD) check. We can pref it off if we can't stabilize it by the time this gets to beta.
Attachment #8476982 - Flags: review?(cpearce) → review+
(Assignee)

Updated

3 years ago
Depends on: 1058399
Created attachment 8479321 [details] [diff] [review]
Enable fmp4 decoder for <video> on MacOS X

Update addressing review comments and changes from bug 1057879. Carrying forward r=cpearce
Attachment #8476982 - Attachment is obsolete: true
Created attachment 8479331 [details] [diff] [review]
Enable fmp4 decoder for <video> on MacOS X

Work around bug 1058897. Carrying forward r=cpearce again.
Attachment #8479321 - Attachment is obsolete: true
Green on try https://tbpl.mozilla.org/?tree=Try&rev=7232395497f6
https://hg.mozilla.org/integration/mozilla-inbound/rev/9da9ea6bd08e
https://hg.mozilla.org/mozilla-central/rev/9da9ea6bd08e
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34

Comment 19

3 years ago
Yes! Thanks to all who made this possible!

Any chance this and any necessary fixes can be uplifted to Fx 33 / Aurora?

This is Lion and newer, right?


Release Note Request (optional, but appreciated)
[Why is this notable]: First time h264 is available on Mac without plugins
[Suggested wording]: (Added) Built-in support for H264 (MP4) on OS X Lion(??) and newer through native APIs.
[Links (documentation, blog post, etc)]: -
relnote-firefox: --- → ?
(In reply to Florian Bender from comment #19)
> Any chance this and any necessary fixes can be uplifted to Fx 33 / Aurora?

There's Buckley's chance of that happening. There are way too many commits to the MP4 parser and related code that this depends on.

Anthony

Comment 21

3 years ago
Yeah I thought so. Thanks anyway!
Depends on: 1061395

Comment 22

3 years ago
With `media.apple.mp4.enabled` set to true, the video on youtube HTML5's player becomes black/blank, the audio for me. A quick fix is to manually toggle that flag to false.

I am using a Late-2009 MacBook running Yosemite public beta 2.
Keywords: dev-doc-needed
(In reply to Jonny Barnes from comment #22)
> With `media.apple.mp4.enabled` set to true, the video on youtube HTML5's
> player becomes black/blank, the audio for me. A quick fix is to manually
> toggle that flag to false.
> 
> I am using a Late-2009 MacBook running Yosemite public beta 2.

This was tracked in bug 1054789, and is thought to be fixed. Can you re-test nightly, and if it still occurs, please file a new bug. Thanks!

Comment 24

3 years ago
(In reply to Chris Pearce (:cpearce) from comment #23)
> (In reply to Jonny Barnes from comment #22)
> > With `media.apple.mp4.enabled` set to true, the video on youtube HTML5's
> > player becomes black/blank, the audio for me. A quick fix is to manually
> > toggle that flag to false.
> > 
> > I am using a Late-2009 MacBook running Yosemite public beta 2.
> 
> This was tracked in bug 1054789, and is thought to be fixed. Can you re-test
> nightly, and if it still occurs, please file a new bug. Thanks!

Nightly works with YouTube as expected now.
Added to the release notes with "Built-in support for H264 (MP4) on Mac OS X Lion and newer through native APIs" as wording.
relnote-firefox: ? → 34+
Also supported on Snow Leopard (10.6). See bug 1070703.
OK, Updated! thanks
Duplicate of this bug: 1085687
MP4 support on Mac OSX has been pushed out to Firefox 35 due to unresolved issues in the demuxer.
Depends on: 1100482
Sylvestre or lmandel, the release notes may need updating here.
Flags: needinfo?(sledru)
Flags: needinfo?(lmandel)
OK. Thanks. Moved to 35 then!
relnote-firefox: 34+ → 35+
Flags: needinfo?(sledru)
Flags: needinfo?(lmandel)

Comment 32

3 years ago
(In reply to Anthony Jones (:kentuckyfriedtakahe, :k17e) from comment #29)
> MP4 support on Mac OSX has been pushed out to Firefox 35 due to unresolved
> issues in the demuxer.

Do you have a link to those issues so that I can follow them?

This is pretty disappointing for us :(
(Assignee)

Updated

3 years ago
Depends on: 1093567
(Assignee)

Updated

3 years ago
Duplicate of this bug: 942130
You need to log in before you can comment on or make changes to this bug.