Closed Bug 1043904 Opened 10 years ago Closed 10 years ago

[Dialer][Call screen] There is a empty line at bottom of background image

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Dialer
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.1 verified)

Status:
VERIFIED FIXED
Milestone:
2.1 S1 (1aug)
Tracking Flags:
Tracking Status
b2g-v2.1 --- verified

People

(Reporter: paco, Assigned: paco)

References

Details

Attachments

(4 files, 1 obsolete file)

callscreen-background-bottom-empty.png
137.55 KB, image/png
Details
line-bottom-call-screen.png
119.54 KB, image/png
Details
patch in github
46 bytes, text/x-github-pull-request
rik
: review+
Details | Review
Verify_image.png
167.50 KB, image/png
Details
Attached image callscreen-background-bottom-empty.png (obsolete) — 
      No description provided.
Assignee: nobody → pacorampas

        Attachment #8462490 -
        Attachment is obsolete: true

    
    

    
  


  

    
    

    
  

      
      
      
      

        Attached file
          
        patch in github
        — 
      

    


  

        Attachment #8462525 -
        Flags: review?(anthony)

    
    

    
  
Comment on attachment 8462525 [details] [review]
patch in github

Why did we keep this background-position if we're using cover? I guess that was an oversight at the time.

        Attachment #8462525 -
        Flags: review?(anthony)

    
    

    
  
Comment on attachment 8462525 [details] [review]
patch in github

I have removed the background position as you said

        Attachment #8462525 -
        Flags: review?(anthony)

    
    

    
  
Comment on attachment 8462525 [details] [review]
patch in github

Sorry, I wanted to mark this as review+ yesterday but somehow just removed the flag… My bad!

        Attachment #8462525 -
        Flags: review?(anthony) → review+

    
    

    
  
Merged: 449d632c69b1a4bd5101d07d18f76799d3fd5f38
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

          status-b2g-v2.1:
          --- → fixed
Target Milestone: --- → 2.1 S1 (1aug)

    
    

    
  
This issue has been verified successfully on Flame 2.1

See attachment: Verify_image.png
Reproducing rate: 0/5
flame2.1 build:
Gaia-Rev        5655269098c7e82254e56933f1af05b4abe2a2f3
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/86608c9389b5
Build-ID        20141204001201
Version         34.0
Status: RESOLVED → VERIFIED

          status-b2g-v2.1:
          fixed → verified

    
    

    
  

      
      
      
      

        Attached image
          
        Verify_image.png
        — 
      

    


  

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: