1044051 - MobileIdentityClient tests

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

We need to write tests for https://mxr.mozilla.org/mozilla-central/source/services/mobileid/MobileIdentityClient.jsm

Probably mochitests with a .sjs mock server

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

Comment 2

[Sam Penrose]

Comment on attachment 8482705 [details] [diff] [review]
v1

Thanks very much for the tests; they are good to have. I ran into:

https://bugzilla.mozilla.org/show_bug.cgi?id=1059883

while running them and was not able to avoid it. Since all of your code works, I see no reason to hold up the review, but you might want to carefully inspect a try build before landing.

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Thanks Sam!

https://tbpl.mozilla.org/?tree=Try&rev=075762ea4157

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/12fb6be094e9

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/12fb6be094e9

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9d487cabd065
https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/928529d945bf

Comment 7

[Kai-Zhen Li [:seinlin][:kli]]

http://hg.mozilla.org/releases/mozilla-b2g32_v2_0m/rev/928529d945bf