Closed Bug 1044051 Opened 5 years ago Closed 5 years ago

MobileIdentityClient tests

Categories

(Core :: DOM: Device Interfaces, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla35
Tracking Status
firefox33 --- wontfix
firefox34 --- fixed
firefox35 --- fixed
b2g-v2.0 --- fixed
b2g-v2.0M --- fixed
b2g-v2.1 --- fixed
b2g-v2.2 --- fixed

People

(Reporter: ferjm, Assigned: ferjm)

References

Details

Attachments

(1 file)

We need to write tests for https://mxr.mozilla.org/mozilla-central/source/services/mobileid/MobileIdentityClient.jsm

Probably mochitests with a .sjs mock server
Assignee: nobody → ferjmoreno
Attached patch v1Splinter Review
Attachment #8482705 - Flags: review?(spenrose)
Comment on attachment 8482705 [details] [diff] [review]
v1

Thanks very much for the tests; they are good to have. I ran into:

https://bugzilla.mozilla.org/show_bug.cgi?id=1059883

while running them and was not able to avoid it. Since all of your code works, I see no reason to hold up the review, but you might want to carefully inspect a try build before landing.
Attachment #8482705 - Flags: review?(spenrose) → review+
https://hg.mozilla.org/mozilla-central/rev/12fb6be094e9
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Blocks: 1045581
Blocks: 1064249
You need to log in before you can comment on or make changes to this bug.