Closed Bug 1044051 Opened 5 years ago Closed 5 years ago
Identity Client tests
We need to write tests for https://mxr.mozilla.org/mozilla-central/source/services/mobileid/MobileIdentityClient.jsm Probably mochitests with a .sjs mock server
Comment on attachment 8482705 [details] [diff] [review] v1 Thanks very much for the tests; they are good to have. I ran into: https://bugzilla.mozilla.org/show_bug.cgi?id=1059883 while running them and was not able to avoid it. Since all of your code works, I see no reason to hold up the review, but you might want to carefully inspect a try build before landing.
Attachment #8482705 - Flags: review?(spenrose) → review+
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.