1044067 - Don't ship new tab page content on Android

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Richard Newman [:rnewman]]

Bug 1036299 added images to toolkit/content/directoryLinks.json, which ends up included in Fennec's build.

This regressed our APK size.

That content should be moved into browser/, or conditionalized to Firefox only.

Ed, could you make that happen, please?

Comment 1

[Ed Lee :Mardak]

When does this need to happen? We'll be switching to remotely hosted directoryLinks.json soon with bug 1042876.

Comment 2

[Ed Lee :Mardak]

To be clear, with the switch to remotely hosted, we'll remove toolkit/content/directoryLinks.json.

Comment 3

[Richard Newman [:rnewman]]

Ideally it happens before we ship too many more Nightly builds with this; we have to be mindful of our storage usage even for our Nightly users.

It definitely needs to happen before this code reaches Beta.

The solution is probably as simple as an #ifdef in a moz.build file somewhere, or moving the file to browser/ and changing a manifest, no?

Comment 4

[Ed Lee :Mardak]

Attachment: wip

Like this? How should I test this? Send to tryserver and unpack to see if the file is there?

Comment 5

[Richard Newman [:rnewman]]

(In reply to Ed Lee :Mardak from comment #4)

> Like this?

That'll exclude it for both Fennec and B2G. If you need it for B2G, we can tweak the conditional.

Moving it into browser/ would be the most correct solution, assuming that you only want to ship this for Firefox, and not for, e.g., Thunderbird and SeaMonkey.

This patch seems acceptable to me if you can't move this out of toolkit for some reason. Build peers might have a different opinion!


> How should I test this? Send to tryserver and unpack to see if
> the file is there?

I can do a local build; save the try resources.

Comment 6

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/15d85e45122d

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/15d85e45122d

Comment 8

[Liz Henry (:lizzard)]

Aaron could you verify this one? Thanks!

Comment 9

[Aaron Train [:aaronmt]]

$ ls chrome/toolkit/content/global/directoryLinks.json
ls: chrome/toolkit/content/global/directoryLinks.json: No such file or directory