1044079 - [meta] Eliminate unnecessary desktop/toolkit resources from Fennec's omni.ja

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Richard Newman [:rnewman]]

Wes noticed in Bug 1044067 that desktop-only resources are ending up in our APK. This meta bug tracks fixing any of those that we find.

It would probably be worthwhile to skim through omni.ja, saying "hey, what's that doing there?".

Comment 1

[Richard Newman [:rnewman]]

Candidates, from a few minutes with ls -lRsa $(find . -type f):

modules/devtools in general is 3.2MB.

90KB: modules/devtools/jsbeautify/beautify-tests.js
60KB: modules/devtools/jsbeautify/beautify-js.js

Why so much XUL stuff?
60KB: chrome/toolkit/content/global/bindings/autocomplete.xml

Looks like B2G stuff:
55KB: modules/PhoneNumberMetaData.jsm
53KB: modules/ContactDB.jsm


Why is our XML not minified?

chrome/toolkit/content/mozapps/extensions/extensions.xml

is full of comments and whitespace:


  <!-- Rating - displays current/average rating, allows setting user rating -->
  <binding id="rating">
    <content>


modules/services-common/storageservice.js
-- this is a Sync client module. What's this doing in our omni.ja?

115KB for a QR code decoder. The least-minified code in the whole world.

modules/devtools/qrcode/decoder/index.js

Comment 2

[Paul Rouget [:paul]]

most of the code in modules/devtools (toolkit/devtools) is required.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Unused omnijar files during testing

Here's a very rough list of omnijar files from Nightly that we *don't* use during test runs. In other words, if we take out these files, all tests should still pass.

#1 in the list, chrome/shumway/content/shumway.js, is not shipped in releases.

#2, modules/commonjs/dev/volcan.js, was added only a week ago. It appears unused but I don't know if there are plans to use it in the future.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

I'm not sure if this fits in here but I noticed that PluginProvider.jsm and OpenH264Provider.jsm are loaded into Fennec, but probably are not needed. Looks like they are loaded via a manifest component category:

http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/extensions.manifest#16

The file already has a MOZ_WIDGET_GONK wrapper. Maybe we could add a nested wrapper around those two lines?

I spotted them when looking at AWSY.com, just looking at what files are in memory after startup.

Comment 5

[Richard Newman [:rnewman]]

Taking a fresh look today:

chrome/en-US/locale/en-US/global-platform/unix/
chrome/en-US/locale/en-US/global-platform/mac/
chrome/en-US/locale/en-US/global-platform/win/
chrome/en-US/locale/en-US/browser/localepicker.properties

chrome/en-US/locale/en-US/global/printPreview.dtd

chrome/toolkit/skin/classic/global/icons/question-24.png
and friends

chrome/pippki/content/pippki/protectedAuth.js
chrome/pippki/content/pippki/protectedAuth.xul
chrome/pippki/content/pippki/resetpassword.js
chrome/pippki/content/pippki/resetpassword.xul
chrome/pippki/content/pippki/setp12password.xul
and friends

Comment 6

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.