1044142 - l10n: update existing locales w/ new strings

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Notes, defect)

Description

[Dylan Oliver [:doliver]]

We've added a few new error strings to the app recently. Need to update the following existing locales:

* es
* fr
* pl
* pt-BR

Comment 1

[Dylan Oliver [:doliver]]

Attachment: PR - update existing locales

Comment 2

[Dylan Oliver [:doliver]]

gandalf, are you an appropriate reviewer for this patch? In addition to the translations you did for pl, the structure of the properties file has been updated (bug 1042826) and we adopted the plurals structure for the relative dates (bug 1024154), so the diffs are larger than one might expect.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

I'd suggest :flod.

Comment 4

[Dylan Oliver [:doliver]]

Comment on attachment 8462838 [details] [review]
PR - update existing locales

Hi Francesco, would you be willing to give this one a look?

Comment 5

[Francesco Lodolo [:flod]]

Comment on attachment 8462838 [details] [review]
PR - update existing locales

I don't see anything wrong. Where are these translations coming from (besides pl)?

One nit about the comments.

> # do not translate <br/> tag ^^^

This is one weird way to comment. One "standard" understood by tools is
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_best_practices#Properties_files

Comment 6

[Dylan Oliver [:doliver]]

(In reply to Francesco Lodolo [:flod] from comment #5)
> Comment on attachment 8462838 [details] [review]
> PR - update existing locales
> 
> I don't see anything wrong. Where are these translations coming from
> (besides pl)?

The bulk of these were provided by everything.me when they handed off the app to us. 

> 
> One nit about the comments.
> 
> > # do not translate <br/> tag ^^^

Ok, I'll clean it up. Thanks.

Comment 7

[Carsten Book [:Tomcat]]

master: https://github.com/mozilla-b2g/notes/commit/1e7b2d13459eeb7789c1fb4987fd5abfad4e6422 was apparently done some 10 hours ago