l10n: update existing locales w/ new strings

RESOLVED FIXED in 2.1 S1 (1aug)

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: doliver, Assigned: doliver)

Tracking

unspecified
2.1 S1 (1aug)
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
We've added a few new error strings to the app recently. Need to update the following existing locales:

* es
* fr
* pl
* pt-BR
(Assignee)

Comment 1

4 years ago
Created attachment 8462838 [details] [review]
PR - update existing locales
(Assignee)

Comment 2

4 years ago
gandalf, are you an appropriate reviewer for this patch? In addition to the translations you did for pl, the structure of the properties file has been updated (bug 1042826) and we adopted the plurals structure for the relative dates (bug 1024154), so the diffs are larger than one might expect.
Flags: needinfo?(gandalf)
(Assignee)

Updated

4 years ago
See Also: → bug 1024154, bug 1042826
I'd suggest :flod.
Flags: needinfo?(gandalf)
(Assignee)

Comment 4

4 years ago
Comment on attachment 8462838 [details] [review]
PR - update existing locales

Hi Francesco, would you be willing to give this one a look?
Attachment #8462838 - Flags: review?(francesco.lodolo)
Comment on attachment 8462838 [details] [review]
PR - update existing locales

I don't see anything wrong. Where are these translations coming from (besides pl)?

One nit about the comments.

> # do not translate <br/> tag ^^^

This is one weird way to comment. One "standard" understood by tools is
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_best_practices#Properties_files
Attachment #8462838 - Flags: review?(francesco.lodolo) → review+
(Assignee)

Comment 6

4 years ago
(In reply to Francesco Lodolo [:flod] from comment #5)
> Comment on attachment 8462838 [details] [review]
> PR - update existing locales
> 
> I don't see anything wrong. Where are these translations coming from
> (besides pl)?

The bulk of these were provided by everything.me when they handed off the app to us. 

> 
> One nit about the comments.
> 
> > # do not translate <br/> tag ^^^

Ok, I'll clean it up. Thanks.
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
(Assignee)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
master: https://github.com/mozilla-b2g/notes/commit/1e7b2d13459eeb7789c1fb4987fd5abfad4e6422 was apparently done some 10 hours ago
Keywords: checkin-needed
Target Milestone: --- → 2.1 S1 (1aug)
You need to log in before you can comment on or make changes to this bug.