1044230 - Port over date checking from yulelog

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Description

[Andy McKay]

Yulelog has some code that checks to see if the date is good on the device. If not, then it shows the user a nice message to the user instead of failing in wierd and wonderful ways when HTTPS goes wrong.

We should port this over.

https://github.com/mozilla/fireplace/blob/master/yulelog/main.js#L94-L107

Think this won't happen to you? My Flame just shipped with a year of 1969.

Comment 1

[Mathieu Pillard [:mat]]

Bonus: we'll be able to properly translate the message !

Comment 2

[Rob Hudson [:robhudson]]

PR: https://github.com/mozilla/fireplace/pull/541

What's missing is the casperjs test. I tried to get one working but felt I was wasting too many cycles getting it to work so moved on to other things.

Comment 3

[Stuart Colville [:muffinresearch]]

Added a test for the flow and clicking the button here: https://github.com/mozilla/fireplace/pull/561 (See the last commit only).

Depends on the casperjs 1.1 test conversion landing first.

Comment 4

[Stuart Colville [:muffinresearch]]

https://github.com/mozilla/fireplace/commit/ac3e6d0da6f5c44583eb3218d952bf2149c99781

Comment 5

[Stuart Colville [:muffinresearch]]

Testing notes:

* Testing this requires changing a device date to the past.
* Then load fireplace it should show the message as per https://github.com/mozilla/fireplace/pull/541#issuecomment-50783491

Comment 6

[Madalin Cotetiu]

I have tested this on an Inari (FFOS 1.3) and Flame (FFOS 2.1) by loading the marketplace-dev.allizom.org (after changing the date)
When I changed the date to a past date (for example june 2004) the right message is displayed : http://screencast.com/t/BJorlrAx
But when changing to a future date the untrusted connection warning is displayed: http://screencast.com/t/mRgwyenoFgS
Same behavior on both devices
I think the same message should be displayed when changing to a future date.
What do you think Stuart?

Comment 7

[Stuart Colville [:muffinresearch]]

(In reply to Madalin Cotetiu from comment #6)
> I have tested this on an Inari (FFOS 1.3) and Flame (FFOS 2.1) by loading
> the marketplace-dev.allizom.org (after changing the date)
> When I changed the date to a past date (for example june 2004) the right
> message is displayed : http://screencast.com/t/BJorlrAx
> But when changing to a future date the untrusted connection warning is
> displayed: http://screencast.com/t/mRgwyenoFgS
> Same behavior on both devices
> I think the same message should be displayed when changing to a future date.
> What do you think Stuart?

I think that's worth a separate bug for sure. The main use-case for this bug is that phones ship with dates set to dates in the past - which is a known issue. I would  think that the future date scenario is less likely but still worth a separate bug.

Comment 8

[Madalin Cotetiu]

I will close this bug as the original issue is fixed.
For the future date scenario I have logged Bug 1058563