1044299 - [RTL][Usage][Cost Control] Cost Control app/Usage app needs to have RTL taken into account

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: 2014-07-25-16-10-53.png

1. set device language to arabic
2. reboot device
3. launch Usage

Expected: RTL styled Cost Control app
Actual:
1. tutorial buttons are conflicted in RTL or LTR
2. checkbox overlap the text on the bottom
3. the settings page has the right side truncated.

Gaia      3a06aa58245eaf848242d6d1497c1af536fffabd
Gecko     https://hg.mozilla.org/mozilla-central/rev/6c0971104909
BuildID   20140725040205
Version   34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230
Flame

Comment 1

[Marina Rodríguez [:mai]]

Attachment: patch v1.0

Hi Salva, 
would you mind reviewing the patch?
Regards

Comment 2

[Marina Rodríguez [:mai]]

Attachment: fix-overlapText.jpg

Attached image to show how the overlapped text is fixed.

Comment 3

[Marina Rodríguez [:mai]]

Attachment: fix-settings.jpg

Attached image to show how is fixed the settings

Comment 4

[Marina Rodríguez [:mai]]

Attachment: fix-tutorialButtons.jpg

Attached image to show how is fixed the order of the fte buttons

Comment 5

[Salvador de la Puente González [:salva]]

Comment on attachment 8466145 [details] [review]
patch v1.0

Ok, the patch looks ok at a higher level. The problem here is that I don't know what are the rtl considerations to take into account here and at which level. I mean, should the chart advance from right to left? should the first time experience wizard advance to the left instead?

I think this is a good starting point but should we file bug for the chart and the wizard too?

Comment 6

[Marina Rodríguez [:mai]]

Master: f49d080ea81ac366bd7843cdee2109031d803bdc

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Comment on attachment 8466145 [details] [review]
patch v1.0

Since this patch already landed and it looks good there doesn't seem for me anything to do...

Just a FYI, there's a thread on dev-gaia about RTL : 
https://groups.google.com/forum/#!searchin/mozilla.dev.gaia/RTL/mozilla.dev.gaia/GzIIlTUKvAg/8kTAE3nYuXgJ

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

fyi mai, see comment 7.

Comment 9

[Marina Rodríguez [:mai]]

Thanks for sharing your knowlegde, Naoki, ;)

Comment 10

[Jeremiah Lee]

Issue is verified fixed on Flame 2.1.

With Arabic enabled, Usage tutorial buttons are not conflicted, there is no checkbox overlap, and the settings page is not truncated.

Device: Flame 2.1 (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141126001202
Gaia: db2e84860f5a7cc334464618c6ea9e92ff82e9dd
Gecko: 211eae88f119
Version: 34.0 (2.1)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 11

[Peter Bylenga [:PBylenga]]

Mass Edit: adding the [rtl-meta]