1044508 - [Keyboard] Stop using HTML in layout definition for 全/半 button

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Keyboard, defect, P2)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

The 全/半 button is currently defined with HTML present in layout definition. We should generalized this into render.js or layout manager or somewhere better just like every other keys since they are used in two places (bug 1021505 and bug 938039).

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

:rudyl, please add this to the roadmap.

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Done, please refer to,
https://wiki.mozilla.org/Gaia/System/Keyboard/Roadmap#Architecture_Improvements

Comment 3

[Raniere Silva]

For the math virtual keyboard (Bug 1004057) I need to use HTML (more specific MathML) for some keys to ensure that the user will get the properly render. Some examples are:

- subscript and superscript: <math><msubsup><mi>x</mi><mi>y</mi><mi>z</mi></msubsup></math>
- n-root: <math><mroot><mi>x</mi><mi>n</mi></mroot></math>
- absolute value: <math><mrow><mo>|</mo><mi>x</mi><mo>|</mo></mrow></math>
- matrices: <math><mtable><mtr><mtd><mi>a</mi></mtd><mtd><mi>b</mi></mtd></mtr></mtable></math>
- hats: <math><mover><mi>x</mi><mo>^</mo></mover></math>

Any alternative?

Comment 4

[[e-mail]]

Attachment: pull request 22770

Hi Tim,
  Do you have time take a look?

  Thanks

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8472228 [details] [review]
pull request 22770

I don't think this patch is good enough because it simply moves the special case handling from layouts to render.js. That said, I don't have better alternatives when I try to think of a better approach.

If there isn't a better way to solve this bug and we have more use case like comment 3, maybe this bug should be closed as invalid.

Comment 6

[[e-mail]]

Agree. Situations like comment 3, I prefer to put them in a single layout file.

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #5)
> Comment on attachment 8472228 [details] [review]
> pull request 22770
> 
> I don't think this patch is good enough because it simply moves the special
> case handling from layouts to render.js. That said, I don't have better
> alternatives when I try to think of a better approach.
> 
> If there isn't a better way to solve this bug and we have more use case like
> comment 3, maybe this bug should be closed as invalid.

Comment 7

[BMO Automation]

Firefox OS is not being worked on