1044601 - OS X Yosemite titlebar/toolbar gradient incorrect

Status: RESOLVED WORKSFORME

(Core :: Widget: Cocoa, defect)

Description

[d.a.]

Attachment: Screen Shot 2014-07-27 at 7.40.30 PM.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:34.0) Gecko/20100101 Firefox/34.0 (Beta/Release)
Build ID: 20140727030204

Steps to reproduce:

In OS X Yosemite the titlebar/toolbar combination will produce an incorrect gradient, see attached screenshot.

Comment 1

[d.a.]

Looks like this was fixed by bug 1055018. Gradient looks OK now.

Comment 2

[:Gijs (he/him)]

(In reply to d.a. from comment #1)
> Looks like this was fixed by bug 1055018. Gradient looks OK now.

I noticed this as well, but it seems to me like the toolbar's gradient might still need updating? Not sure.

Comment 3

[d.a.]

(In reply to :Gijs Kruitbosch from comment #2)
> (In reply to d.a. from comment #1)
> > Looks like this was fixed by bug 1055018. Gradient looks OK now.
> 
> I noticed this as well, but it seems to me like the toolbar's gradient might
> still need updating? Not sure.

Maybe it looks a touch too light, but at least the gradient isn't broken in two. So gradient could be tweaked I guess. The best would probably be if the toolbars could blur the website contents, but it may be to hard to do with how the window gets drawn.

Comment 4

[:Gijs (he/him)]

(In reply to d.a. from comment #3)
> (In reply to :Gijs Kruitbosch from comment #2)
> > (In reply to d.a. from comment #1)
> > > Looks like this was fixed by bug 1055018. Gradient looks OK now.
> > 
> > I noticed this as well, but it seems to me like the toolbar's gradient might
> > still need updating? Not sure.
> 
> Maybe it looks a touch too light, but at least the gradient isn't broken in
> two. So gradient could be tweaked I guess. The best would probably be if the
> toolbars could blur the website contents, but it may be to hard to do with
> how the window gets drawn.

Yeah, this is part of bug 1050804 and friends. The idea is for the titlebar/tabs to use the 'light' vibrancy that sidebars and such use elsewhere on Yosemite, with the navigation toolbar potentially showing the website contents. However, as you say, this is difficult. :-)

However, my point was that without this working, the navigation toolbar looks quite dark as compared to the tabs toolbar / titlebar? As I said, not sure. Maybe I just need to get used to it? :-)

Markus, do you think we need a color update for the navbar still?

Comment 5

[Markus Stange [:mstange]]

(In reply to :Gijs Kruitbosch from comment #4)
> Markus, do you think we need a color update for the navbar still?

Yes, I think we do, at least until we have the blurred website contents. (But even then we'd need some CSS to put a gradient on top...)

You may want to do this in a new bug though, because it looks like this bug was about regular unified toolbars in non-browser windows.