Closed
Bug 1044607
Opened 10 years ago
Closed 10 years ago
remove `hasListenerFor` method from content worker
Categories
(Add-on SDK Graveyard :: General, defect, P2)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla35
People
(Reporter: zombie, Assigned: zombie)
References
Details
Attachments
(1 file)
as far as i can see, the only place this is still used is in context-menu, and i can work around that. keeping it would require (moar) hacks for the e10s content worker (if "less code is better" is not a good enough reason for the removal.. ;)
|
Assignee | |
Updated•10 years ago
|
Summary: remove `hasListenerFor` from content worker API → remove `hasListenerFor` method from content worker
|
|
Assignee | |
Comment 1•10 years ago
|
||
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8463153 [details] [review] Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1567 Looks good to me.
Attachment #8463153 -
Flags: review?(rFobic) → review+
Priority: -- → P2
Did this still need to land?
Flags: needinfo?(tomica+amo)
|
|
Assignee | |
Comment 4•10 years ago
|
||
this was mostly related to bug 1028718, which is now moot.. nevertheless, i might as well land, as less code is better anyway..
Flags: needinfo?(tomica+amo)
|
||
Comment 5•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/e66cbf314f8fe5808c1dd2ffd0b2834929801b44 bug 1044607 - remove hasListenerFor https://github.com/mozilla/addon-sdk/commit/33c9231f9b86f42573c06534009f609ca70b5fe5 Merge pull request #1567 from zombie/1044607-hasListenerFor bug 1044607 - remove hasListenerFor, r=@gozala
|
|
Assignee | |
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•