1044657 - Move PYTHON_UNIT_TESTS to moz.build

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Move PYTHON_UNIT_TESTS to moz.build

As a first step, this moves PYTHON_UNIT_TESTS to moz.build as a passthru
variable. In the future, we could hook it up to |mach test|.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/users/Ms2ger_gmail.com/bxr/rev/e4770792ae04

Comment 3

[Michael Shal [:mshal]]

Comment on attachment 8463163 [details] [diff] [review]
Move PYTHON_UNIT_TESTS to moz.build

>+PYTHON_UNIT_TESTS += [
>+    '../build/compare-mozconfig/compare-mozconfigs-wrapper.py',
>+]

Any idea if we can move this into build/moz.build? Seems weird to have it referenced from browser (although the mozconfigs it checks are under browser, the test is in build).


>+PYTHON_UNIT_TESTS += [
>+    'mach/mach/test/__init__.py',

Do we really need all of these __init__.py files? Or things like common.py?

Comment 4

[(not currently active) Ted Mielczarek]

(In reply to Michael Shal [:mshal] from comment #3)
> Any idea if we can move this into build/moz.build? Seems weird to have it
> referenced from browser (although the mozconfigs it checks are under
> browser, the test is in build).


The intent was to only run them under Firefox builds, IIRC, so sticking them under browser/ was the simplest way to accomplish that. We could move this to build/ and just check CONFIG['MOZ_APP_NAME'] instead.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/56f392ebff92

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/56f392ebff92