Bug 847009 (nomakefiles)

Move all data into moz.build files

NEW
Unassigned

Status

()

Core
Build Config
4 years ago
4 months ago

People

(Reporter: Ms2ger, Unassigned)

Tracking

(Depends on: 34 bugs, Blocks: 3 bugs, {meta})

Trunk
Points:
---
nomakerules, 847066, 847536, 853594, 866734, 868539, 870396, 870806, 870815, 881446, 882907, 882908, 883503, 887958, 899889, 914247, 928735, 929296, 929298, 1113622, 1208120, 1208130, 1223340, 1223530, 1223535, 1253607, 1254492, 1254953, 1255042, 1256010, 1256012, 1256604, 1256608, 1337008, 774572, 784841, 818246, 844654, 844655, 846634, 850389, 852814, 854530, 862986, 864774, 865673, 868158, 868536, 869135, 869143, 870076, 870366, 870370, 870376, 870394, 870401, 870406, 870407, 870408, 870801, 870802, 870891, 872059, 872062, 872086, 872087, 874266, 875549, 875934, 880245, 880246, 880254, 880260, 880773, 881341, 881344, 881345, 882190, 882738, 882904, 882906, 883284, 883348, 883350, 883351, 883353, 885019, 887012, 887832, 888009, 888643, 891632, 893045, 894052, 894543, 897458, 897909, 897921, 898895, 900522, 900530, 900937, 901988, 901990, 904831, 906342, 906343, 906351, 906412, 906696, 908038, 908142, 910540, 912197, 914245, 914270, 914272, 914273, 914274, 915928, 916918, 920185, 922268, 922288, 922566, 923395, 928709, 930674, 930849, 931404, 931459, 931461, 931462, 932213, 937224, 937258, 968856, 968900, 976733, 978591, 1020165, 1042226, 1042878, 1043963, 1044111, 1044445, 1044446, 1044657, 1046784, 1111814, 1112426, 1134633, 1135138, 1137364, 1137437, 1142513, 1160185, 1186444, 1194603, 1198226, 1217015, 1223529, 1223745, 1224165, 1224308, 1230750, 1248016, 1248020, 1250616, 1250961, 1251372, 1251704, 1252092, 1252093, 1252094, 1252095, 1252112, 1252804, 1252931, 1253431, 1254115, 1254120, 1254950, 1255359, 1256011, 1256033, 1256642, 1269787, 1270621, 1272483, 1272488, 1273579, 1275355, 1275356
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Comment hidden (empty)
(Reporter)

Updated

4 years ago
Depends on: 784841
Depends on: 774572, 844654, 844655

Updated

4 years ago
Depends on: 847066

Updated

4 years ago
Alias: nomakefiles
(Reporter)

Updated

4 years ago
Blocks: 774049
Depends on: 847536
Depends on: 850389

Updated

4 years ago
Depends on: 852814

Updated

4 years ago
Depends on: 853594
Depends on: 769378
Depends on: 854530
Depends on: 862986
Blocks: 864191

Updated

4 years ago
Blocks: 827343

Updated

4 years ago
Depends on: 864774

Updated

4 years ago
Depends on: 865673

Updated

4 years ago
Depends on: 868536

Updated

4 years ago
Depends on: 868539

Updated

4 years ago
Depends on: 868158
Depends on: 869143
Depends on: 869135

Updated

4 years ago
Depends on: 870076

Updated

4 years ago
Depends on: 870366

Updated

4 years ago
Depends on: 870370

Updated

4 years ago
Depends on: 870376

Updated

4 years ago
Depends on: 870394

Updated

4 years ago
Depends on: 870396

Updated

4 years ago
Depends on: 870401

Updated

4 years ago
Depends on: 870406

Updated

4 years ago
Depends on: 870407

Updated

4 years ago
Depends on: 870408
Depends on: 870815, 870806, 870801, 870802

Updated

4 years ago
Depends on: 872059

Updated

4 years ago
Depends on: 872062

Updated

4 years ago
Depends on: 872086

Updated

4 years ago
Depends on: 874266
Depends on: 872087
Depends on: 875934

Updated

4 years ago
Depends on: 880245

Updated

4 years ago
Depends on: 880246

Updated

4 years ago
Depends on: 880254

Updated

4 years ago
Depends on: 880260

Updated

4 years ago
Depends on: 880773

Updated

4 years ago
Depends on: 881341

Updated

4 years ago
Depends on: 881344

Updated

4 years ago
Depends on: 881345

Updated

4 years ago
Depends on: 881446

Updated

4 years ago
Depends on: 875549

Updated

4 years ago
Depends on: 882738

Updated

4 years ago
Depends on: 882904

Updated

4 years ago
Depends on: 882907

Updated

4 years ago
Depends on: 882906
(Reporter)

Updated

4 years ago
Depends on: 883284

Updated

4 years ago
Depends on: 883348

Updated

4 years ago
Depends on: 883350

Updated

4 years ago
Depends on: 883351

Updated

4 years ago
Depends on: 883353
Caveat emptor on mozbuild migration:

The output of moz.build is included at the head of config/rules.mk, before config/config.mk is included. However, some Makefiles take it upon themselves to include config/config.mk themselves (typically, because they think they want to override a variable defined there before using rules.mk). Thus, moz.build variables which effect [1] things in config/config.mk may cause things to break for those files; I first noticed this with LIBRARY_NAME. This is probably a risk for many of the library-related variables.

[1] Grammar nazis: that is a correct spelling there. :-)
(Reporter)

Updated

4 years ago
Depends on: 883503

Updated

4 years ago
Depends on: 885019
(Reporter)

Updated

4 years ago
Depends on: 887012

Updated

4 years ago
Depends on: 887832

Updated

4 years ago
Depends on: 887958

Updated

4 years ago
Depends on: 888009
(Reporter)

Updated

4 years ago
Depends on: 888643

Updated

4 years ago
Depends on: 891632
Depends on: 892603

Updated

4 years ago
Depends on: 893045

Comment 2

4 years ago
(In reply to Joshua Cranmer [:jcranmer] from comment #1)
> Caveat emptor on mozbuild migration:
> 
> The output of moz.build is included at the head of config/rules.mk, before
> config/config.mk is included. However, some Makefiles take it upon
> themselves to include config/config.mk themselves (typically, because they
> think they want to override a variable defined there before using rules.mk).
> Thus, moz.build variables which effect [1] things in config/config.mk may
> cause things to break for those files; I first noticed this with
> LIBRARY_NAME. This is probably a risk for many of the library-related
> variables.
> 
> [1] Grammar nazis: that is a correct spelling there. :-)

After trying to fix similar issues during freshly fetched 
TB (comm-central) configure,
first : HOST_CSRCS in mozill/config/moz.build (Bug 893045)
(commenting out how it goes, then)
second :NO_DIST_INSTALL  in ./mozilla/build/unix/elfhack/moz.build
(again, commenting out how it goes, then)
thirdly I hit LIBRARY_NAME in mozilla/mfbt/moz.build

Hmm... I have no idea how to fix these, and so I have given up
on local TB build for now. 
I am wondering how TB TryServer is handling these(?)

TIA
(In reply to ISHIKAWA, Chiaki from comment #2)
> After trying to fix similar issues during freshly fetched 
> TB (comm-central) configure,
> first : HOST_CSRCS in mozill/config/moz.build (Bug 893045)
> (commenting out how it goes, then)
> second :NO_DIST_INSTALL  in ./mozilla/build/unix/elfhack/moz.build
> (again, commenting out how it goes, then)
> thirdly I hit LIBRARY_NAME in mozilla/mfbt/moz.build
> 
> Hmm... I have no idea how to fix these, and so I have given up
> on local TB build for now. 
> I am wondering how TB TryServer is handling these(?)

As I mentioned in the bug you filed, this smells very much like you have a broken checkout of mozilla-central. In particular, it sounds like you accidentally have an out-of-date copy of certain files under python/mozbuild while having non-out-of-date copies of the moz.build files.
No longer depends on: 892603

Comment 4

4 years ago
(In reply to Joshua Cranmer [:jcranmer] from comment #3)
> (In reply to ISHIKAWA, Chiaki from comment #2)
> > After trying to fix similar issues during freshly fetched 
> > TB (comm-central) configure,
> > first : HOST_CSRCS in mozill/config/moz.build (Bug 893045)
> > (commenting out how it goes, then)
> > second :NO_DIST_INSTALL  in ./mozilla/build/unix/elfhack/moz.build
> > (again, commenting out how it goes, then)
> > thirdly I hit LIBRARY_NAME in mozilla/mfbt/moz.build
> > 
> > Hmm... I have no idea how to fix these, and so I have given up
> > on local TB build for now. 
> > I am wondering how TB TryServer is handling these(?)
> 
> As I mentioned in the bug you filed, this smells very much like you have a
> broken checkout of mozilla-central. In particular, it sounds like you
> accidentally have an out-of-date copy of certain files under python/mozbuild
> while having non-out-of-date copies of the moz.build files.

Thank you. Clobbering was required to solve this.
The version I checked out was very new as far as I could figure out (only less than 24 hours ago.)
comm-central (top)
 hg identify
  c29c9f0c7405 tip
(M-C portion) ./mozilla
 hg identify
6ee949cbeb03+ 893045-fix.patch/qbase/qtip/tip

(There was one patch to fix the issue mentioned in bug 893045)

After re-fetching the comm-central, just in case into a new directory,
clobbering, configure succeeded and compilation is proceeding.

TIA

Updated

4 years ago
Depends on: 894052

Updated

4 years ago
Depends on: 894543

Updated

4 years ago
Depends on: 882190

Updated

4 years ago
Depends on: 866734
(Reporter)

Updated

4 years ago
Depends on: 897458
(Reporter)

Updated

4 years ago
Depends on: 897909
(Reporter)

Updated

4 years ago
Depends on: 897921
(Reporter)

Updated

4 years ago
Depends on: 898895

Updated

4 years ago
Depends on: 899889

Updated

4 years ago
Depends on: 900522

Updated

4 years ago
Depends on: 900530

Updated

4 years ago
Depends on: 900937

Updated

4 years ago
Depends on: 901981

Updated

4 years ago
Depends on: 901988

Updated

4 years ago
Depends on: 901990

Updated

4 years ago
Depends on: 904831
(Reporter)

Updated

4 years ago
Depends on: 906342
(Reporter)

Updated

4 years ago
Depends on: 906343
(Reporter)

Updated

4 years ago
Depends on: 906351
(Reporter)

Updated

4 years ago
Depends on: 906412
(Reporter)

Updated

4 years ago
Depends on: 906696
(Reporter)

Updated

4 years ago
Depends on: 910540

Updated

4 years ago
Depends on: 912197

Updated

4 years ago
Depends on: 908142

Updated

4 years ago
Depends on: 914245
(Reporter)

Updated

4 years ago
Depends on: 914247

Updated

4 years ago
Depends on: 914270

Updated

4 years ago
Depends on: 914272

Updated

4 years ago
Depends on: 914273

Updated

4 years ago
Depends on: 916918

Updated

4 years ago
Depends on: 920185
(Reporter)

Updated

4 years ago
Depends on: 915928
(Reporter)

Updated

4 years ago
Depends on: 922268
(Reporter)

Updated

4 years ago
Depends on: 922288

Updated

4 years ago
Depends on: 922566
(Reporter)

Updated

4 years ago
Depends on: 923395
(Reporter)

Updated

4 years ago
Depends on: 914274
Depends on: 928709
(Reporter)

Updated

4 years ago
Depends on: 928735
Depends on: 929296
Depends on: 929298
Depends on: 930674

Updated

4 years ago
Depends on: 930849
(Reporter)

Updated

4 years ago
Depends on: 931404
(Reporter)

Updated

4 years ago
Depends on: 931459
(Reporter)

Updated

4 years ago
Depends on: 931461
(Reporter)

Updated

4 years ago
Depends on: 931462
(Reporter)

Updated

4 years ago
Depends on: 932213
(Reporter)

Updated

4 years ago
Depends on: 937224
(Reporter)

Updated

4 years ago
Depends on: 937258
(Reporter)

Updated

3 years ago
Depends on: 968856
(Reporter)

Updated

3 years ago
Depends on: 968900

Updated

3 years ago
Depends on: 882908
Depends on: 976733
(Reporter)

Updated

3 years ago
Depends on: 1020165
(Reporter)

Updated

3 years ago
Depends on: 1043963
Depends on: 1044111
Depends on: 1044445
Depends on: 1044446
(Reporter)

Updated

3 years ago
Depends on: 1044657
Depends on: 1046784

Updated

3 years ago
Depends on: 1042878
Depends on: 1042226
Depends on: 1111814
Depends on: 1112426
Depends on: 1113622
Depends on: 1134633
(Reporter)

Updated

2 years ago
Depends on: 1135138
Depends on: 1137437
Depends on: 1137364
(Reporter)

Updated

2 years ago
Depends on: 1142513
Depends on: 870891
Depends on: 978591
Depends on: 1160185
Depends on: 1186444
(Reporter)

Updated

2 years ago
Depends on: 1194603
Depends on: 1198226
Depends on: 1208120
Depends on: 1208130
Depends on: 1217015
Depends on: 1223340
Depends on: 1223529
Depends on: 1223530
Depends on: 1223535
Depends on: 1223745
Depends on: 1224165
Depends on: 1224308
Depends on: 1230750
Depends on: 1248020
Depends on: 1248016
Depends on: 1250961
(Reporter)

Updated

a year ago
(Reporter)

Updated

a year ago
Depends on: 1252112
(Reporter)

Updated

a year ago
Depends on: 1251704
(Reporter)

Updated

a year ago
Depends on: 1252804
Depends on: 1252931
Depends on: 1253431
Depends on: 1253607
(Reporter)

Updated

a year ago
Depends on: 908038
Depends on: 1254120
Depends on: 1254492
(Reporter)

Updated

a year ago
Depends on: 1251372, 1250616
Depends on: 1254950
Depends on: 1254953
Depends on: 1255042
Depends on: 1255359
Depends on: 1256010
Depends on: 1256011
Depends on: 1256012
Depends on: 1256033
Depends on: 1256604
Depends on: 1256608
Depends on: 1256642
No longer depends on: 901981
Depends on: 1337008
You need to log in before you can comment on or make changes to this bug.