Open Bug 847009 (nomakefiles) Opened 7 years ago Updated 11 months ago

[meta] Move all data into moz.build files

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

People

(Reporter: Ms2ger, Unassigned)

References

(Depends on 50 open bugs, Blocks 2 open bugs)

Details

(Keywords: meta)

No description provided.
Depends on: 784841
Depends on: 847066
Alias: nomakefiles
Blocks: 774049
Depends on: 847536
Depends on: 850389
Depends on: 852814
Depends on: 853594
Depends on: nomakerules
Depends on: 862986
Blocks: buildtup
Depends on: 864774
Depends on: 865673
Depends on: 868536
Depends on: 868539
Depends on: 868158
Depends on: 869143
Depends on: 869135
Depends on: 870076
Depends on: 870366
Depends on: 870370
Depends on: 870376
Depends on: 870394
Depends on: 870396
Depends on: 870401
Depends on: 870406
Depends on: 870407
Depends on: 870408
Depends on: 870815, 870806, 870801, 870802
Depends on: 872059
Depends on: 872062
Depends on: 872086
Depends on: 874266
Depends on: 872087
Depends on: 875934
Depends on: 880245
Depends on: 880246
Depends on: 880254
Depends on: 880260
Depends on: 880773
Depends on: 881341
Depends on: 881344
Depends on: 881345
Depends on: 881446
Depends on: 875549
Depends on: 882738
Depends on: 882904
Depends on: 882907
Depends on: 882906
Depends on: 883284
Depends on: 883348
Depends on: 883350
Depends on: 883351
Depends on: 883353
Caveat emptor on mozbuild migration:

The output of moz.build is included at the head of config/rules.mk, before config/config.mk is included. However, some Makefiles take it upon themselves to include config/config.mk themselves (typically, because they think they want to override a variable defined there before using rules.mk). Thus, moz.build variables which effect [1] things in config/config.mk may cause things to break for those files; I first noticed this with LIBRARY_NAME. This is probably a risk for many of the library-related variables.

[1] Grammar nazis: that is a correct spelling there. :-)
Depends on: 883503
Depends on: 885019
Depends on: 887012
Depends on: 887832
Depends on: 887958
Depends on: 888009
Depends on: 888643
Depends on: 891632
Depends on: 893045
(In reply to Joshua Cranmer [:jcranmer] from comment #1)
> Caveat emptor on mozbuild migration:
> 
> The output of moz.build is included at the head of config/rules.mk, before
> config/config.mk is included. However, some Makefiles take it upon
> themselves to include config/config.mk themselves (typically, because they
> think they want to override a variable defined there before using rules.mk).
> Thus, moz.build variables which effect [1] things in config/config.mk may
> cause things to break for those files; I first noticed this with
> LIBRARY_NAME. This is probably a risk for many of the library-related
> variables.
> 
> [1] Grammar nazis: that is a correct spelling there. :-)

After trying to fix similar issues during freshly fetched 
TB (comm-central) configure,
first : HOST_CSRCS in mozill/config/moz.build (Bug 893045)
(commenting out how it goes, then)
second :NO_DIST_INSTALL  in ./mozilla/build/unix/elfhack/moz.build
(again, commenting out how it goes, then)
thirdly I hit LIBRARY_NAME in mozilla/mfbt/moz.build

Hmm... I have no idea how to fix these, and so I have given up
on local TB build for now. 
I am wondering how TB TryServer is handling these(?)

TIA
(In reply to ISHIKAWA, Chiaki from comment #2)
> After trying to fix similar issues during freshly fetched 
> TB (comm-central) configure,
> first : HOST_CSRCS in mozill/config/moz.build (Bug 893045)
> (commenting out how it goes, then)
> second :NO_DIST_INSTALL  in ./mozilla/build/unix/elfhack/moz.build
> (again, commenting out how it goes, then)
> thirdly I hit LIBRARY_NAME in mozilla/mfbt/moz.build
> 
> Hmm... I have no idea how to fix these, and so I have given up
> on local TB build for now. 
> I am wondering how TB TryServer is handling these(?)

As I mentioned in the bug you filed, this smells very much like you have a broken checkout of mozilla-central. In particular, it sounds like you accidentally have an out-of-date copy of certain files under python/mozbuild while having non-out-of-date copies of the moz.build files.
(In reply to Joshua Cranmer [:jcranmer] from comment #3)
> (In reply to ISHIKAWA, Chiaki from comment #2)
> > After trying to fix similar issues during freshly fetched 
> > TB (comm-central) configure,
> > first : HOST_CSRCS in mozill/config/moz.build (Bug 893045)
> > (commenting out how it goes, then)
> > second :NO_DIST_INSTALL  in ./mozilla/build/unix/elfhack/moz.build
> > (again, commenting out how it goes, then)
> > thirdly I hit LIBRARY_NAME in mozilla/mfbt/moz.build
> > 
> > Hmm... I have no idea how to fix these, and so I have given up
> > on local TB build for now. 
> > I am wondering how TB TryServer is handling these(?)
> 
> As I mentioned in the bug you filed, this smells very much like you have a
> broken checkout of mozilla-central. In particular, it sounds like you
> accidentally have an out-of-date copy of certain files under python/mozbuild
> while having non-out-of-date copies of the moz.build files.

Thank you. Clobbering was required to solve this.
The version I checked out was very new as far as I could figure out (only less than 24 hours ago.)
comm-central (top)
 hg identify
  c29c9f0c7405 tip
(M-C portion) ./mozilla
 hg identify
6ee949cbeb03+ 893045-fix.patch/qbase/qtip/tip

(There was one patch to fix the issue mentioned in bug 893045)

After re-fetching the comm-central, just in case into a new directory,
clobbering, configure succeeded and compilation is proceeding.

TIA
Depends on: 894052
Depends on: 894543
Depends on: 882190
Depends on: 866734
Depends on: 897458
Depends on: 897909
Depends on: 897921
Depends on: 898895
Depends on: 899889
Depends on: 900522
Depends on: 900530
Depends on: 900937
Depends on: 901981
Depends on: 901988
Depends on: 901990
Depends on: 904831
Depends on: 906342
Depends on: 906343
Depends on: 906351
Depends on: 906412
Depends on: 906696
Depends on: 910540
Depends on: 912197
Depends on: 908142
Depends on: 914245
Depends on: 914247
Depends on: 914270
Depends on: 914272
Depends on: 914273
Depends on: 916918
Depends on: 920185
Depends on: 915928
Depends on: 922268
Depends on: 922288
Depends on: 922566
Depends on: 923395
Depends on: 914274
Depends on: 928709
Depends on: 928735
Depends on: 930849
Depends on: 931404
Depends on: 931459
Depends on: 931461
Depends on: 931462
Depends on: 932213
Depends on: 937224
Depends on: 937258
Depends on: 968856
Depends on: 968900
Depends on: 882908
Depends on: 1020165
Depends on: 1043963
Depends on: 1044111
Depends on: 1044445
Depends on: 1044446
Depends on: 1044657
Depends on: 1046784
Depends on: 1042878
Depends on: 1042226
Depends on: 1111814
Depends on: 1112426
Depends on: 1113622
Depends on: 1134633
Depends on: 1135138
Depends on: 1137437
Depends on: 1137364
Depends on: 1142513
Depends on: 870891
Depends on: 978591
Depends on: 1160185
Depends on: 1186444
Depends on: 1194603
Depends on: 1217015
Depends on: 1252112
Depends on: 1251704
Depends on: 1252804
Depends on: 1253431
Depends on: 908038
Depends on: 1251372, 1250616
Depends on: 1256033
No longer depends on: 901981
Depends on: 1255485
Depends on: 1407374
Depends on: 1281618
Depends on: 1407427
Depends on: 1407433
Depends on: 1259530
Depends on: 1407442
Product: Core → Firefox Build System
Depends on: 1451275
No longer depends on: 1407427
Summary: Move all data into moz.build files → [meta] Move all data into moz.build files
You need to log in before you can comment on or make changes to this bug.