1044982 - [Flatfish][FTU] The "Join hidden network" gray button in "Select network" screen is truncated.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[eva.chen.fx]

Attachment: [FTU] Join hidden network.jpg

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/36.0.1985.125 Safari/537.36

Steps to reproduce:

Reproducible: Always
1. Flash a fresh build on the tablet. Begin navigation through the first time setup screen.
2. Choose a Language.
3. Tap the next button
4. On the "Select a network" page, swipe up to go "Join hidden network" button.
<ISSUE> The "Join hidden network" gray button in "Select a network" screen is truncated.

-----------------------------------------------
Environment Informations:
DUT: Flatfish
Gaia: a5f93c8ba175ae83fac6b7740a8414459fbd7a5b(2014-07-27 16:05:28)
B2G: 2.1.0.0-prerelease
Platform version : 34.0a1


Actual results:

The "Join hidden network" gray button is truncated.


Expected results:

The button "Join hidden network" is not truncated in the FTU.

Comment 1

[Sherman Chen [:chens] (inactive)]

Attachment: Pull request

Comment 2

[Sherman Chen [:chens] (inactive)]

Attachment: FTUJoinNetworkButton.png

Comment 3

[Fernando Campo (:fcampo)]

Comment on attachment 8465237 [details] [review]
Pull request

This looks like a regression (AFAIK it was not happening on 1.3), and if it is, I'd like better to chase the origin and fix it than apply a specific patch as a workaround.

Comment 4

[Fernando Campo (:fcampo)]

Asking for QA per comment 3.

I tested it on the flatfish I just received from the tablet contribution program (comes with build 20140120153642) and working fine.

NOTE: to repro, we need to have enough wifi-networks available so we have to swipe through the list to get to the 'hidden network' button.

Comment 5

[Sherman Chen [:chens] (inactive)]

I think this comes from building blocks update, having different height in gaia-buttons for different resolution. And this change is applied after May 20.

[1] https://github.com/mozilla-b2g/gaia/blob/master/shared/elements/gaia_buttons/style.css#L16
[2] https://github.com/mozilla-b2g/gaia/blob/master/shared/elements/gaia_buttons/style.css#L212

Comment 6

[Sherman Chen [:chens] (inactive)]

FYI, daily build for tablet contributor can be found here: https://www.dropbox.com/sh/b2py1btcwstqldl/AABblbq_csa1IHQwdvLdfptTa

Comment 7

[Fernando Campo (:fcampo)]

(In reply to Sherman Chen [:chens] from comment #5)
> I think this comes from building blocks update, having different height in
> gaia-buttons for different resolution. And this change is applied after May
> 20.
> 
> [1]
> https://github.com/mozilla-b2g/gaia/blob/master/shared/elements/gaia_buttons/
> style.css#L16
> [2]
> https://github.com/mozilla-b2g/gaia/blob/master/shared/elements/gaia_buttons/
> style.css#L212
So confirmed that it is a regression from bug 1010990, I talked with Arnau about it, and we'd rather to take this small patch now than to change the structure (to flexbox) to avoid this recalculations. That should be done eventually, but not in here (maybe on FTE long waited refactor).


(In reply to Sherman Chen [:chens] from comment #6)
> FYI, daily build for tablet contributor can be found here:
> https://www.dropbox.com/sh/b2py1btcwstqldl/AABblbq_csa1IHQwdvLdfptTa
Thanks!! I was actually looking for builds this morning, super useful!

Comment 8

[Fernando Campo (:fcampo)]

Comment on attachment 8465237 [details] [review]
Pull request

Thanks for the patch and the explanation Sherman, kudos!

Comment 9

[Sherman Chen [:chens] (inactive)]

Merged to master 
https://github.com/mozilla-b2g/gaia/commit/e6802da3a407f0a04c1cccf1bc0accc8dd285076

Comment 10

[eva.chen.fx]

The issue is resolved with a build Gaia from today's master.
Verified okay on Flatfish.
BuildID: 20140804012121
Gaia: a2d748f55624021563ec998845c2426286e81f5d
Version: 34.0a1