Give Treeherder URLs alongside TBPL ones in the hg.mozilla.org push response

RESOLVED FIXED

Status

Developer Services
Mercurial: hg.mozilla.org
P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Details

(Whiteboard: [treeherder])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
+++ This bug was initially created as a clone of Bug #1043880 +++

Similar to bug 1043880 except for the hg hook that generates the URLs in the Hg serve response when pushing to hg.mozilla.org
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

3 years ago
Priority: -- → P1
(Assignee)

Comment 1

3 years ago
Created attachment 8464805 [details] [diff] [review]
push_printurls: Also give Treeherder URL for viewing job results
Attachment #8464805 - Flags: review?(hwine)
(Assignee)

Comment 2

3 years ago
I should add: treeherder has to have lowercase repo names - I filed bug 1046225 for making this more tolerant - however it makes sense for us to use the canonical name in this patch (the lowercase one) either way.
Comment on attachment 8464805 [details] [diff] [review]
push_printurls: Also give Treeherder URL for viewing job results

Review of attachment 8464805 [details] [diff] [review]:
-----------------------------------------------------------------

okay after try-comm-central is fixed or explained.

::: mozhghooks/push_printurls.py
@@ +107,5 @@
>          tip_node = short(repo.changectx(tip).node())
>          print 'You can view the progress of your build at the following URL:'
>          print '  https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=%s' % tip_node
> +        print 'Alternatively, view them on Treeherder (experimental):'
> +        print '  https://treeherder.mozilla.org/ui/#/jobs?repo=thunderbird-try&revision=%s' % tip_node

If treeherder uses the "real" name of the repo, then this should be "try-comm-central"
Attachment #8464805 - Flags: review?(hwine) → review+
(Assignee)

Comment 4

3 years ago
(In reply to Hal Wine [:hwine] (use needinfo) from comment #3)
> If treeherder uses the "real" name of the repo, then this should be
> "try-comm-central"

It doesn't - compare:
https://treeherder.mozilla.org/ui/#/jobs?repo=comm-central-try
https://treeherder.mozilla.org/ui/#/jobs?repo=thunderbird-try

I'm not entirely sure yet how the repo mappings are handled in treeherder, but for now this is the link we need to use (or we can just omit it, I really don't mind). We'll have to update these URLs post bug 1042737 anyway :-)
(Assignee)

Comment 5

3 years ago
https://hg.mozilla.org/hgcustom/hghooks/rev/52f75a0ae929
(Assignee)

Updated

3 years ago
Depends on: 1046562
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Comment 6

3 years ago
https://hg.mozilla.org/hgcustom/version-control-tools/rev/1f927bcba52c
(Assignee)

Updated

3 years ago
Blocks: 1072161
Product: Release Engineering → Developer Services
(Assignee)

Comment 7

3 years ago
Updated to shorter URL form (without the /ui/), now that bug 1063411 is fixed:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/11b0ae516977
You need to log in before you can comment on or make changes to this bug.