1045023 - [Vertical Homescreen] No icons on homescreen with DEBUG=1 mode on nightly take 2

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Gabriele Svelto [:gsvelto]]

+++ This bug was initially created as a clone of Bug #1027555 +++

Steps to Reproduce:

1. Build Gaia with DEBUG=1 flag
2. Running Gaia on Nightly

Actual Results:
No icons appear and this error is logged to the console

JavaScript error: app://verticalhome.gaiamobile.org/js/sources/application.js, line 258: GaiaGrid is not defined

This is a different issue from bug 1027555 but it seems to be related to the fix which moved the gaia_grid shared component to after the inclusion of app.js

Expected Results:
Vertical homescreen with icons and app name

Environment Informations:
- gaia/master d9afe81149d83ce34fbb68769c5820415580f6f7

Comment 1

[Gabriele Svelto [:gsvelto]]

Attachment: [PATCH] Ensure that the GaiaGrid component is loaded before it is used

Quick fix that shuffles the sources around so that we don't hit this issue. I've also removed the verticalhomescreen from the apps-engineering.list, it was probably forgotten there when it became the default.

Comment 2

[Gabriele Svelto [:gsvelto]]

Attachment: [PULL REQUEST] Ensure that the GaiaGrid component is loaded before it is used

Pull request for the patch above.

Comment 3

[Jason Smith [:jsmith]]

This is a blocker for development given that this would prevent you from debugging the Firefox OS phone effectively, right? If so, can you nominate this to block?

Also - do you know if this is present on 2.0 as well?

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8463360 [details] [review]
[PULL REQUEST] Ensure that the GaiaGrid component is loaded before it is used

FYI - I don't mind stealing this review if you want to mark me as reviewier and clear Vivien's R?. Thanks!

Comment 5

[Gabriele Svelto [:gsvelto]]

(In reply to Jason Smith [:jsmith] from comment #3)
> This is a blocker for development given that this would prevent you from
> debugging the Firefox OS phone effectively, right? If so, can you nominate
> this to block?

Debugging on the phone is fine, it's developing in the desktop browser that doesn't work because the new homescreen never starts. In fact I find it a little strange that this is working correctly on the phone; there must be something different in how the app starts up on the device.

> Also - do you know if this is present on 2.0 as well?

I'm not sure, I've been unable to get v2.0 to work from within nightly.

Comment 6

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8463359 [details] [diff] [review]
[PATCH] Ensure that the GaiaGrid component is loaded before it is used

(In reply to Kevin Grandon :kgrandon from comment #4)
> FYI - I don't mind stealing this review if you want to mark me as reviewier
> and clear Vivien's R?. Thanks!

Sure :)

Comment 7

[Gabriele Svelto [:gsvelto]]

Try was green: https://tbpl.mozilla.org/?rev=1a7a887d0dc94d259bde381f718a69b86c2814e5&tree=Gaia-Try

Pushed to gaia/master 50a8b19acde8737c61cac4ad4c33ce79d7e60127