Closed Bug 1045085 Opened 5 years ago Closed 5 years ago

Remove Product Announcements

Categories

(Android Background Services Graveyard :: Product Announcements, defect)

Firefox 34
All
Android
defect
Not set

Tracking

(firefox33 fixed, firefox34 fixed)

RESOLVED FIXED
Firefox 34
Tracking Status
firefox33 --- fixed
firefox34 --- fixed

People

(Reporter: rnewman, Assigned: rnewman)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Wake up! It's time to die!
Depends on: 1045087
This is based on <https://github.com/mozilla-services/android-sync/pull/473>. It's here as an hg patch so that file removals are correct.

Note that the patch in Bug 1045087 is necessary for complete function.
Attachment #8463548 - Flags: review?(michael.l.comella)
Blocks: 1045278
Comment on attachment 8463548 [details] [diff] [review]
Remove main Product Announcements code. v1

Review of attachment 8463548 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm w/ nit on gh.
Attachment #8463548 - Flags: review?(michael.l.comella) → review+
https://hg.mozilla.org/mozilla-central/rev/2175dc19592a
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Comment on attachment 8463548 [details] [diff] [review]
Remove main Product Announcements code. v1

We'd like this on Beta. Might as well kill it early.

Approval Request Comment
[Feature/regressing bug #]:
  N/A
[User impact if declined]:
  N/A
[Describe test coverage new/current, TBPL]:
  N/A -- feature removal.
[Risks and why]: 
  Feature removal. Low risk.
[String/UUID change made/needed]:
  None.
Attachment #8463548 - Flags: approval-mozilla-beta?
Comment on attachment 8463548 [details] [diff] [review]
Remove main Product Announcements code. v1

Although a big patch, this is a pretty small change. I agree with the risk assessment and the upside is that we can discontinue the server side of this feature 6 weeks earlier. Beta+
Attachment #8463548 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
ni on me for a non-Ryan landing :D
Flags: needinfo?(rnewman)
Ryan et al: the reason this didn't land cleanly is that it depends on Bug 1045087, which removes the integration points for this code. I flagged that for beta; it's also a safe change.
You need to log in before you can comment on or make changes to this bug.