1045085 - Remove Product Announcements

Status: RESOLVED FIXED

(Android Background Services Graveyard :: Product Announcements, defect)

Description

[Richard Newman [:rnewman]]

Wake up! It's time to die!

Comment 1

[JR Conlin [:jrconlin,:jconlin]]

woot!

Comment 2

[Richard Newman [:rnewman]]

Attachment: Remove main Product Announcements code. v1

This is based on <https://github.com/mozilla-services/android-sync/pull/473>. It's here as an hg patch so that file removals are correct.

Note that the patch in Bug 1045087 is necessary for complete function.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8463548 [details] [diff] [review]
Remove main Product Announcements code. v1

Review of attachment 8463548 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm w/ nit on gh.

Comment 4

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/2175dc19592a

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2175dc19592a

Comment 6

[Richard Newman [:rnewman]]

Comment on attachment 8463548 [details] [diff] [review]
Remove main Product Announcements code. v1

We'd like this on Beta. Might as well kill it early.

Approval Request Comment
[Feature/regressing bug #]:
  N/A
[User impact if declined]:
  N/A
[Describe test coverage new/current, TBPL]:
  N/A -- feature removal.
[Risks and why]: 
  Feature removal. Low risk.
[String/UUID change made/needed]:
  None.

Comment 7

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8463548 [details] [diff] [review]
Remove main Product Announcements code. v1

Although a big patch, this is a pretty small change. I agree with the risk assessment and the upside is that we can discontinue the server side of this feature 6 weeks earlier. Beta+

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/776ddfd41f21

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Backed out from beta for bustage.
https://hg.mozilla.org/releases/mozilla-beta/rev/70930f30da0e

https://tbpl.mozilla.org/php/getParsedLog.php?id=47618054&tree=Mozilla-Beta

Comment 10

[Richard Newman [:rnewman]]

ni on me for a non-Ryan landing :D

Comment 11

[Richard Newman [:rnewman]]

Ryan et al: the reason this didn't land cleanly is that it depends on Bug 1045087, which removes the integration points for this code. I flagged that for beta; it's also a safe change.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d5ed7dd8f996