Remove Product Announcements from Fennec settings and pref broadcaster

VERIFIED FIXED in Firefox 33

Status

()

VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: rnewman, Assigned: rnewman)

Tracking

(Blocks: 1 bug)

34 Branch
Firefox 34
All
Android
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox33 verified, firefox34 verified)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8463551 [details] [diff] [review]
Remove Product Announcements integration points from Fennec. v1

Note that there are two omissions here:

* We don't clean up the Fennec pref that tracks whether announcements are enabled. Neither do we clean up the product announcements prefs themselves (e.g., last fetch).
* We no longer track last startup. I need to audit to make sure we're not using that elsewhere.
Attachment #8463551 - Flags: review?(mark.finkle)
Comment on attachment 8463551 [details] [diff] [review]
Remove Product Announcements integration points from Fennec. v1

This part looks good
Attachment #8463551 - Flags: review?(mark.finkle) → review+
(Assignee)

Updated

4 years ago
Blocks: 1045278
https://hg.mozilla.org/mozilla-central/rev/ad7d3c6f8bde
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
(Assignee)

Comment 5

4 years ago
Comment on attachment 8463551 [details] [diff] [review]
Remove Product Announcements integration points from Fennec. v1

Trivial dependency of Bug 1045085, which is approved for Beta.

This just removes the Settings screen, the prefs broadcaster, **one string**, and the manifest includes for the service that we delete in Bug 1045085.
Attachment #8463551 - Flags: approval-mozilla-beta?
Attachment #8463551 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
https://hg.mozilla.org/releases/mozilla-beta/rev/c0ba357c4c89

With string changes omitted to appease the l10n gods.
status-firefox33: --- → fixed
status-firefox34: --- → fixed
'Show product announcements' doesn't appear anymore in Settings -> Mozilla, so I'll mark this as verified fixed.
Builds:
Firefox for Android 33
Firefox for Android 34 Beta 2
Device:
Asus Transformer Pad TF300T (Android 4.2.1)
Status: RESOLVED → VERIFIED
status-firefox33: fixed → verified
status-firefox34: fixed → verified
You need to log in before you can comment on or make changes to this bug.