1045087 - Remove Product Announcements from Fennec settings and pref broadcaster

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Comment 1

[Richard Newman [:rnewman]]

Attachment: Remove Product Announcements integration points from Fennec. v1

Note that there are two omissions here:

* We don't clean up the Fennec pref that tracks whether announcements are enabled. Neither do we clean up the product announcements prefs themselves (e.g., last fetch).
* We no longer track last startup. I need to audit to make sure we're not using that elsewhere.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8463551 [details] [diff] [review]
Remove Product Announcements integration points from Fennec. v1

This part looks good

Comment 3

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/ad7d3c6f8bde

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ad7d3c6f8bde

Comment 5

[Richard Newman [:rnewman]]

Comment on attachment 8463551 [details] [diff] [review]
Remove Product Announcements integration points from Fennec. v1

Trivial dependency of Bug 1045085, which is approved for Beta.

This just removes the Settings screen, the prefs broadcaster, **one string**, and the manifest includes for the service that we delete in Bug 1045085.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c0ba357c4c89

With string changes omitted to appease the l10n gods.

Comment 7

[Cristina Madaras, QA [:CristinaM]]

'Show product announcements' doesn't appear anymore in Settings -> Mozilla, so I'll mark this as verified fixed.
Builds:
Firefox for Android 33
Firefox for Android 34 Beta 2
Device:
Asus Transformer Pad TF300T (Android 4.2.1)