No description provided.
Note that there are two omissions here: * We don't clean up the Fennec pref that tracks whether announcements are enabled. Neither do we clean up the product announcements prefs themselves (e.g., last fetch). * We no longer track last startup. I need to audit to make sure we're not using that elsewhere.
Attachment #8463551 - Flags: review?(mark.finkle)
Comment on attachment 8463551 [details] [diff] [review] Remove Product Announcements integration points from Fennec. v1 This part looks good
Attachment #8463551 - Flags: review?(mark.finkle) → review+
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Comment on attachment 8463551 [details] [diff] [review] Remove Product Announcements integration points from Fennec. v1 Trivial dependency of Bug 1045085, which is approved for Beta. This just removes the Settings screen, the prefs broadcaster, **one string**, and the manifest includes for the service that we delete in Bug 1045085.
Attachment #8463551 - Flags: approval-mozilla-beta?
Attachment #8463551 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
https://hg.mozilla.org/releases/mozilla-beta/rev/c0ba357c4c89 With string changes omitted to appease the l10n gods.
'Show product announcements' doesn't appear anymore in Settings -> Mozilla, so I'll mark this as verified fixed. Builds: Firefox for Android 33 Firefox for Android 34 Beta 2 Device: Asus Transformer Pad TF300T (Android 4.2.1)
You need to log in before you can comment on or make changes to this bug.