Closed
Bug 1045245
Opened 11 years ago
Closed 11 years ago
Remove text icon from settings ImageButton
Categories
(Firefox for Android Graveyard :: Search Activity, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 34
People
(Reporter: eedens, Assigned: eedens)
References
Details
Attachments
(1 file)
|
3.06 KB,
patch
|
Margaret
:
review+
|
Details | Diff | Splinter Review |
The search activity's ImageButton uses a drawable to create its three dots. There is a text attribute for providing the three dots that can be removed.
Follow-up from bug 1022105.
|
Assignee | |
Comment 1•11 years ago
|
||
For settings button:
- Remove text attribute
- Add content description
Attachment #8463650 -
Flags: review?(margaret.leibovic)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8463650 [details] [diff] [review]
bug-1045245-fix.patch
Review of attachment 8463650 [details] [diff] [review]:
-----------------------------------------------------------------
::: mobile/android/search/strings/search_strings.dtd
@@ +10,5 @@
> <!ENTITY search_pref_title 'Settings'>
> <!ENTITY search_pref_clear_history_confirmation 'History cleared'>
> <!ENTITY search_pref_clear_history_dialog_message 'Delete all search history from this device?'>
> <!ENTITY search_pref_clear_history_title 'Clear search history'>
> +<!ENTITY search_pref_button_content_description 'Settings'>
We should be sure to update this if we ever turn this button into a proper menu button, rather than directly launching a settings activity.
Attachment #8463650 -
Flags: review?(margaret.leibovic) → review+
|
|
||
Comment 3•11 years ago
|
||
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
|
||
Updated•8 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•