1045245 - Remove text icon from settings ImageButton

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[Eric Edens [:eedens]]

The search activity's ImageButton uses a drawable to create its three dots. There is a text attribute for providing the three dots that can be removed.

Follow-up from bug 1022105.

Comment 1

[Eric Edens [:eedens]]

Attachment: bug-1045245-fix.patch

For settings button: 
 - Remove text attribute
 - Add content description

Comment 2

[:Margaret Leibovic]

Comment on attachment 8463650 [details] [diff] [review]
bug-1045245-fix.patch

Review of attachment 8463650 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/search/strings/search_strings.dtd
@@ +10,5 @@
>  <!ENTITY search_pref_title 'Settings'>
>  <!ENTITY search_pref_clear_history_confirmation 'History cleared'>
>  <!ENTITY search_pref_clear_history_dialog_message 'Delete all search history from this device?'>
>  <!ENTITY search_pref_clear_history_title 'Clear search history'>
> +<!ENTITY search_pref_button_content_description 'Settings'>

We should be sure to update this if we ever turn this button into a proper menu button, rather than directly launching a settings activity.

Comment 3

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/3b5441abe2c5

Comment 4

[Eric Edens [:eedens]]

Merged: https://github.com/ericedens/FirefoxSearch/commit/670ea8a49587f2a44478c450aef59d554d0bb61a

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3b5441abe2c5