1045330 - Radicale caldav server is _never_ installed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Gareth Aye [:gaye] (back from PTO)]

STR:

```
|APP=calendar make test-integration|

> The Radicale CalDAV server is not installed in the virtualenv, we will skip the CalDAV tests.

|make caldav-server-install|

> source tests/travis_ci/venv.sh; \
				export LC_ALL=en_US.UTF-8; \
				export LANG=en_US.UTF-8; \
				pip install radicale;
Requirement already satisfied (use --upgrade to upgrade): radicale in ./travis_venv/lib/python2.7/site-packages
Cleaning up...


|APP=calendar make test-integration|

> The Radicale CalDAV server is not installed in the virtualenv, we will skip the CalDAV tests.

```

Expected behavior is that, after running |make caldav-server-install|, the caldav server tests will be run against radicale. Right now, the server gets installed, but there's a bug in ./bin/gaia-marionette that makes it so that the code path that adds the caldav tests to the skip list gets taken even if the radicale server is installed.

Comment 1

[Gareth Aye [:gaye] (back from PTO)]

Hey Evan -- do you want to take a look?

Comment 2

[Evan Tseng [:evanxd]]

Sure, I will work on this after I finish Bug 1023663.

Comment 3

[Evan Tseng [:evanxd]]

Gareth, I'll take a look in this sprint. 12/24 format took me much time in last sprint.

Comment 4

[Evan Tseng [:evanxd]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24277/files

Comment 5

[Evan Tseng [:evanxd]]

Comment on attachment 8492974 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24277/files

Hi James,

Could you help to review the patch?

Thanks.

Comment 6

[James Lal [:lightsofapollo]]

Comment on attachment 8492974 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24277/files

LGTM merge on greeen

Comment 7

[Evan Tseng [:evanxd]]

Thanks for the review, James.
The tbpl job[1] is green.

[1] https://tbpl.mozilla.org/?rev=2d17a3be6efb0a5e5157af357283eb8cf982b364&tree=Gaia-Try

Comment 8

[Evan Tseng [:evanxd]]

master: https://github.com/mozilla-b2g/gaia/commit/b2a24fc9f0bfa0a1ad9eea9292febd57d76c2fa8