1023663 - [User story] Calendar day view should start at 8 AM

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Comment 1

[Harly Hsu[:harly]]

Attachment: [2.1 Calendar] 8AM Day View_Draft.pdf

Comment 2

[Harly Hsu[:harly]]

Attachment: [2.1 Calendar] 8AM Day View_v1.0.pdf

Comment 4

[Dylan Oliver [:doliver]]

Evan, you may want to take a look at the patch on Bug 805573 to see if that code can be re-used or incorporated into your fix here.

Comment 5

[Evan Tseng [:evanxd]]

Hi Dylan,

Thanks for this.

I was investigating the smooth scrolling things.

Comment 6

[Evan Tseng [:evanxd]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22352

Currently, the patch is for ui review. It is not ready for code review.

Comment 7

[Evan Tseng [:evanxd]]

Comment on attachment 8465321 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22352

Hi Harly,

Could you help to do the ui-review?

Thanks.

Comment 8

[Harly Hsu[:harly]]

Attachment: [2.1 Calendar] 8AM Day View_v1.1.pdf

Comment 9

[Harly Hsu[:harly]]

Comment on attachment 8465321 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22352

Hi Evan, I have added a new spec to auto scroll to an hour before current time in current day view. Other than that, the patch looks great. Thanks!!

Comment 10

[Evan Tseng [:evanxd]]

Hi Harly,

I already updated the patch for the an hour before thing.
Thanks for the review.

Comment 11

[Evan Tseng [:evanxd]]

Hi Harly,

I think your meaning is these three bug depend on Bug 1023663.

Comment 12

[Evan Tseng [:evanxd]]

Comment on attachment 8465321 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22352

Hi Miller,

Could you help to review the patch?
I will add(fix) the related unit/marionette tests after the first round review.

Thanks.

Comment 13

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8465321 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22352

added a few comments about the code

Comment 14

[Candice Serran (:cserran)]

Hey guys this was targeted to land in sprint 1, is this moving along? Thanks

Comment 15

[Evan Tseng [:evanxd]]

Hi Candice,

We're doing code review now, and the ux review is done.
I think we could land this in this week.

Comment 16

[Evan Tseng [:evanxd]]

Comment on attachment 8465321 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22352

Hi Miller,

If the patch[1] looks OK, I will add/fix the unit/marionette tests tomorrow.
And then I will send you review the test code again.

Thanks.

[1] https://github.com/mozilla-b2g/gaia/pull/22352

Comment 17

[Miller Medeiros [:millermedeiros]]

Evan, the code is looking good! I did not spend too much time looking at the test tho since you said you had to fix/add some things. Thanks!

Comment 18

[Evan Tseng [:evanxd]]

Hi Harly and Peko,

For the scrolling effect, we could use the `ease` effect. How do you think?

Comment 19

[Peko Chen [:pekochen]]

Hi Evan,

yes, I agree with you.
The `ease` effect is better.
thanks!!

Comment 21

[Harly Hsu[:harly]]

Thanks Evan,
The ease effect fell much better than the constant speed effect.
Thank you for adding it.

Comment 22

[Evan Tseng [:evanxd]]

Comment on attachment 8465321 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22352

Hi Miller,

I updated for the comments.
Could you help to review the patch?

Thanks.

Comment 23

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8465321 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22352

looking good! only thing that annoys me should be fixed by Bug 1047283. good work.

PS: it looks like it broke one of integration tests (TEST-UNEXPECTED-FAIL | /builds/slave/test/gaia/apps/calendar/test/marionette/day_view_test.js | day view events longer than 2h click after event end)

Comment 24

[Evan Tseng [:evanxd]]

Hi Miller,

Thanks for the review.
I already fixed the day_view_test.js failure.
For the failures of Gip and Gij[1] are due to Bug 1048953.

[1] https://tbpl.mozilla.org/?rev=cca49194eb6dc78724a4daa3677c5e62ec66d01a&tree=Gaia-Try

Comment 25

[Evan Tseng [:evanxd]]

master: db50c8d84054c0286c3ea355feae32ee4a51c82c

Comment 26

[Edward Chen[:edchen]]

Test case: https://moztrap.mozilla.org/manage/cases/?pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-tag=2968

Comment 27

[Edward Chen[:edchen]]

[Environment]
Gaia      c8e93dadeaec6a2617b4db8b7d65ba14aa8db378
Gecko     https://hg.mozilla.org/mozilla-central/rev/c14e5feadc61
BuildID   20140821160203
Version   34.0a1
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014

[Functional testing Result]
4 out of 4 testcases are passed for the 2014-08-21 Flame.