1045568 - [Loop] Second time trying to log-in with FxAccount (if you aren't logged in general settings FxAcc), the loop app crashes (blocked with logo "authenticating...")

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Javier de Prado]

Device: FireE
Loop version: 08b040a
Build: flame_light-JB.user.master.B-56.Gecko-cc3c2e4.Gaia-8dd303f

1.- Sign out from Settings->FxAccounts
2.- Open Loop, and try to log-in with FxAccount
3.- Close screen where you can create an account or you can sign in.
4.- Push the button "Use Firefox Accounts" another once.
5.- ...and try to close the sign-in screen again.

ACTUAL RESULT
Loop is permanently blocked trying to authenticate.

EXPECTED RESULT
Return to the main lopp screen.

Comment 1

[Jordan de Geus(JordanD)]

I am also encountering this issue when attempting to sign in to a account via Mobile ID.

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

Please just update the tracking flag here. No need to comment.

Comment 3

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue still occurs on the latest 2.0 build with the v165 KK base. The authentication screen remains indefinitely.

Environmental Variables:
Device: Flame 2.0
BuildID: 20140820030000
Gaia: 806d37a264743e04a3e1493136486f3e00124e1e
Gecko: 6329352ca531b977979451e77e5862af485388b2
Version: 32.0 (2.0) 
Firmware Version: v165
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Loop version: 8c71431

Comment 4

[Borja Salguero [:borjasalguero]]

Attachment: Pull Request

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8480524 [details] [review]
Pull Request

I have found out a 2-line patch that fixes the issue. I'll attach it and request feedback at you Borja.

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

Attachment: 1045568.patch

Give a try and let me know please. Thanks!

Comment 7

[Borja Salguero [:borjasalguero]]

Comment on attachment 8481472 [details] [diff] [review]
1045568.patch

Review of attachment 8481472 [details] [diff] [review]:
-----------------------------------------------------------------

The issue is bigger than this (actually this is the same as  https://github.com/mozilla-b2g/firefoxos-loop-client/pull/104/files#diff-fc46f0e3c600d6f85aa05fabf83c3187R182), because it's not just the second request, is that after than request the UI is completely frozen if the server fails.
However, I'll use your approach for checking if the user was logged previously or not because we could save the creation of new vars in our code. Thanks!

Comment 8

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8480524 [details] [review]
Pull Request

LGTM. r=me

Thanks Borja and sorry for causing so much noise on this review.

Comment 9

[Borja Salguero [:borjasalguero]]

Comment on attachment 8480524 [details] [review]
Pull Request

Strings were updated with the latest ones, so ready to merge!

Comment 10

[Javier de Prado]

Now, The authentication screen remains indefinitely trying to authenticate, long tapping on the homescreen button in the FxAccount login proccess. 


Device: Flame
Loop version: c28eaef
Build: flame-kk.user.v2.0.gecko-2d2ca12.gaia-7edd3b0

1.- Sign out from Settings->FxAccounts
2.- Open Loop, and try to log-in with FxAccount
3.- Try to change to another app (long tap home button)

ACTUAL RESULT
Loop is permanently blocked trying to authenticate.

EXPECTED RESULT
Return to the main lopp screen.

Comment 11

[Maria Angeles Oteo (:oteo)]

The issue reported initially in the description of this bug is resolved and working as expected.
So I am closing this bug as Resolved-Fixed.

Javier, I am creating another bug to track the issue you are reporting in comment 10 (bug 1068356). I am seeing it too but I think it's better we handle it in a different bug as they are not exactly the same

Comment 12

[mbarone]

Tested with Flame (v2.0 kk v180)
Gecko-9362b48.Gaia-6449cc3
Loop version 041ff17