Closed
Bug 1045568
Opened 10 years ago
Closed 10 years ago
[Loop] Second time trying to log-in with FxAccount (if you aren't logged in general settings FxAcc), the loop app crashes (blocked with logo "authenticating...")
Categories
(Firefox OS Graveyard :: Gaia::Loop, defect)
Tracking
(b2g-v2.0 affected)
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
b2g-v2.0 | --- | affected |
People
(Reporter: javier.deprado, Assigned: borjasalguero)
References
Details
(Whiteboard: [mobile app][blocking][patch available])
Attachments
(2 files)
Device: FireE Loop version: 08b040a Build: flame_light-JB.user.master.B-56.Gecko-cc3c2e4.Gaia-8dd303f 1.- Sign out from Settings->FxAccounts 2.- Open Loop, and try to log-in with FxAccount 3.- Close screen where you can create an account or you can sign in. 4.- Push the button "Use Firefox Accounts" another once. 5.- ...and try to close the sign-in screen again. ACTUAL RESULT Loop is permanently blocked trying to authenticate. EXPECTED RESULT Return to the main lopp screen.
Comment 1•10 years ago
|
||
I am also encountering this issue when attempting to sign in to a account via Mobile ID.
Comment 2•10 years ago
|
||
Please just update the tracking flag here. No need to comment.
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage-]
Flags: needinfo?(ktucker) → needinfo?(jdegeus)
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage-] → [QAnalyst-Triage?]
Flags: needinfo?(jdegeus) → needinfo?(ktucker)
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage+][lead-review+]
Comment 3•10 years ago
|
||
This issue still occurs on the latest 2.0 build with the v165 KK base. The authentication screen remains indefinitely. Environmental Variables: Device: Flame 2.0 BuildID: 20140820030000 Gaia: 806d37a264743e04a3e1493136486f3e00124e1e Gecko: 6329352ca531b977979451e77e5862af485388b2 Version: 32.0 (2.0) Firmware Version: v165 User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0 Loop version: 8c71431
Updated•10 years ago
|
Whiteboard: [mobile app][blocking]
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8480524 -
Flags: ui-review?(hello)
Attachment #8480524 -
Flags: review?(josea.olivera)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → borja.bugzilla
Hardware: x86 → ARM
Updated•10 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [mobile app][blocking] → [mobile app][blocking][patch available]
Comment 5•10 years ago
|
||
Comment on attachment 8480524 [details] [review] Pull Request I have found out a 2-line patch that fixes the issue. I'll attach it and request feedback at you Borja.
Attachment #8480524 -
Flags: review?(josea.olivera)
Comment 6•10 years ago
|
||
Give a try and let me know please. Thanks!
Attachment #8481472 -
Flags: feedback?(borja.bugzilla)
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8481472 [details] [diff] [review] 1045568.patch Review of attachment 8481472 [details] [diff] [review]: ----------------------------------------------------------------- The issue is bigger than this (actually this is the same as https://github.com/mozilla-b2g/firefoxos-loop-client/pull/104/files#diff-fc46f0e3c600d6f85aa05fabf83c3187R182), because it's not just the second request, is that after than request the UI is completely frozen if the server fails. However, I'll use your approach for checking if the user was logged previously or not because we could save the creation of new vars in our code. Thanks!
Attachment #8481472 -
Flags: feedback?(borja.bugzilla) → feedback-
Assignee | ||
Updated•10 years ago
|
Attachment #8480524 -
Flags: review?(josea.olivera)
Comment 8•10 years ago
|
||
Comment on attachment 8480524 [details] [review] Pull Request LGTM. r=me Thanks Borja and sorry for causing so much noise on this review.
Attachment #8480524 -
Flags: review?(josea.olivera) → review+
Assignee | ||
Comment 9•10 years ago
|
||
Comment on attachment 8480524 [details] [review] Pull Request Strings were updated with the latest ones, so ready to merge!
Attachment #8480524 -
Flags: ui-review?(hello)
Assignee | ||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 10•10 years ago
|
||
Now, The authentication screen remains indefinitely trying to authenticate, long tapping on the homescreen button in the FxAccount login proccess. Device: Flame Loop version: c28eaef Build: flame-kk.user.v2.0.gecko-2d2ca12.gaia-7edd3b0 1.- Sign out from Settings->FxAccounts 2.- Open Loop, and try to log-in with FxAccount 3.- Try to change to another app (long tap home button) ACTUAL RESULT Loop is permanently blocked trying to authenticate. EXPECTED RESULT Return to the main lopp screen.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 11•10 years ago
|
||
The issue reported initially in the description of this bug is resolved and working as expected. So I am closing this bug as Resolved-Fixed. Javier, I am creating another bug to track the issue you are reporting in comment 10 (bug 1068356). I am seeing it too but I think it's better we handle it in a different bug as they are not exactly the same
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Comment 12•10 years ago
|
||
Tested with Flame (v2.0 kk v180) Gecko-9362b48.Gaia-6449cc3 Loop version 041ff17
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•