1068356 - Authentication screen remains indefinitely when long tapping on the homescreen button in the FxAccount login proccess

Status: VERIFIED FIXED

(Firefox OS Graveyard :: FxA, defect)

Description

[Maria Angeles Oteo (:oteo)]

Bug reported by Javier in Comment 10 of bug 1045568 but we need to track separately.

Device: Flame
Loop version: c28eaef
Build: flame-kk.user.v2.0.gecko-2d2ca12.gaia-7edd3b0

1.- Sign out from Settings->FxAccounts
2.- Open Loop, and try to log-in with FxAccount
3.- Try to change to another app (long tap home button)

ACTUAL RESULT
Loop is permanently blocked trying to authenticate.

EXPECTED RESULT
Return to the main loop screen.

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24178

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

[Blocking Requested - why for this release]: This makes users to be blocked in apps like Loop that blocks the UI while the FxA flow is being executed and expect a result from this flow. Without this patch, this result will never be given to the app and so the user will be blocked until the app is restarted via task manager.

Comment 4

[Maria Angeles Oteo (:oteo)]

[Blocking Requested - why for this release]: Same than above, already explained by Fernando, just changing that we need this fix for 2.0 as Loop Mobile Client is going to be launched on that version

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

Alive, I also took the chance to do the proper clean up of the mobile ID dialog as we do with the FxA one.

Comment 6

[KTucker [:KTucker][Inactive 3/4/2016]]

Adding qawanted for branch checks.

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8491461 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24178

r=me

Comment 8

[Fernando Jiménez Moreno [:ferjm]]

Thanks!

https://github.com/mozilla-b2g/gaia/commit/53b97ac4f26b8f3d56148ac5c8e8cba89dd8558a

Comment 9

[Adam Alldredge [:AdamA][Inactive]]

This issue is occurring on 2.1 Flame, 2.0 Flame, and 2.0 Flame Base.

Environmental Variables:
Device: Flame 2.1
BuildID: 20140919105218
Gaia: d558bd001edee9defa017bd67551d43878077932
Gecko: 0d23cb46b0f3
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.0
BuildID: 20140919041249
Gaia: 31434a3949556171f3565ca47ac2b44e810e95e6
Gecko: fb1589259e4f
Version: 32.0 (2.0)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Device: Flame 2.0
BuildID: 20140904160718 (Base)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Result:
Opening card view while authenticating prevents the process from completing.

Comment 10

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8491461 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24178

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): FxA system dialog
[User impact] if declined: his makes users to be blocked in apps like Loop that blocks the UI while the FxA flow is being executed and expect a result from this flow. Without this patch, this result will never be given to the app and so the user will be blocked until the app is restarted via task manager.
[Testing completed]: Manual tests done and unit tests added
[Risk to taking this patch] (and alternatives if risky): Low risk
[String changes made]: None

Comment 11

[Wayne Chang [:wchang]]

Bhavana-

Please see approval/blocking requests from above.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/109515933628b8728beef9331a0035d55e9563a6

Comment 13

[Dietrich Ayala (:dietrich)]

Triage group reviewed, blocking+ due to broken new feature and low risk landing.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/95a51689acd0488b3ba79abe2423cdcc132fff4a

Comment 15

[Kai-Zhen Li [:seinlin][:kli]]

v2.0m: https://github.com/mozilla-b2g/gaia/commit/95a51689acd0488b3ba79abe2423cdcc132fff4a

Comment 16

[Javier de Prado]

Verified on flame (Gecko-b3429ef.Gaia-c6c6116) and fireE (firee-kk-v2.0-SW2E3-1)
Loop version: 1.1 , 2168965