1045593 - Reduce complexity of changeset/results collapsing

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[:Paolo Amadini]

Showing only the revision log or only the job list at different times can be useful, but having this choice per individual row isn't so much, and makes the interface more complex than needed. Proposal:

* Remove the buttons to enable/disable revisions and jobs from individual rows.
* Replace the "collapse/expand" dropdown with two toggle buttons (or a group of three select buttons) to decide what to show.
* It should not be possible to use these toolbar buttons to hide both the revisions and the the jobs. Collapsing rows should be handled by the expand/collapse rows interface (bug 1045592).

The state of these buttons should be remembered per window.

Comment 1

[Ed Morley [:emorley]]

I like the sound of this. I guess the only decision to make it whether we feel the job count and commit count should still be displayed (as text rather than a button). If so (I feel it does add some value), then this bug does simplify things still, but just not as much.

Comment 2

[:Paolo Amadini]

I think the main difference is in the fact that there is one less possible per-row type of interaction, and two less button to memorize, which leaves mental space for more useful functionality in the row headers.

I implied that the total job count could be retained, though not in an interactive-style UI element. But thinking about it, it's probably not important enough to warrant space, might as well be in a tooltip. I didn't even notice the revision count, for me it can be in a tooltip or even removed.

Comment 3

[Ed Morley [:emorley]]

I think we should:
1) Not allow people to hide the jobs - if they want to view the commit log at full width, then let's link to pushloghtml
2) Not allow per-push collapsing/hiding of changesets, and only have a global toggle for it.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Personally, I can't recall a time where I've ever purposely collapsed the results from a single push.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Or full-width pushes. So ++ to both of those :)

Comment 6

[Ed Morley [:emorley]]

I think the only use case for collapsing per push is where someone presses the "collapse all" global button, so the display just shows a handful of compact rows for the pushes, and then you can uncollapse the one you are interested in. Or at least that is how jeads demoed it a while back, but I think that was still when he was thinking that the UI would be able to load on-demand each push for best performance (which obviously doesn't work for a sheriffing workflow).

Comment 8

[Ed Morley [:emorley]]

Oh and I'd completely forgotten: Not only do we have per push collapsing of jobs - we have per push collapsing of jobs _by result_.

So you can click on the "84 running" label and show/hide running just for that push lol.

I'm hopeful we can remove so much code here.

Comment 9

[:Paolo Amadini]

That's the spirit! :-)

Comment 11

[Ed Morley [:emorley]]

This will be fixed by one of the commits in:
https://github.com/mozilla/treeherder-ui/pull/354/commits

Comment 12

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/0f2a0c2d17206c7b3b774c533f7445ba6434f0ad
Bug 1045593 - Remove hiding jobs

Comment 13

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/979cddf89ec286e0ce223dec9a63c1f5a386ca5e
Bug 1045593 - Remove hiding jobs