1) Edges gesture > "before each" hook: Error: timeout exceeded! at Object.Client.waitForSync (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:682:16) at Object.Client.waitFor (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:650:60) at Context.<anonymous> (/home/travis/build/mozilla-b2g/gaia/apps/system/test/marionette/edges_gesture_test.js:46:12) at callFn (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:223:21) at Hook.Runnable.run (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:216:7) at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:258:10) at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:270:7 at done (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:185:5) at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:199:9 at Object.executeHook (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:369:18) at process._tickCallback (node.js:415:13)
Disabled on Travis in: https://github.com/mozilla-b2g/gaia/commit/689bec4562158447298d955822167d58ccf0244f
Keywords: intermittent-failure, leave-open
Created attachment 8493778 [details] [review] Gaia PR Got 100 consecutive run locally (on a tbpl-like setup where I could reproduce the intermittence). Will do more try-runs but this is ready for review.
Comment on attachment 8493778 [details] [review] Gaia PR Code seems fine to me semantically, though I feel like we may be masking the possibility of detecting reflows for a real client in the future.
Attachment #8493778 - Flags: review?(kgrandon) → review+
(In reply to Kevin Grandon :kgrandon from comment #5) > Comment on attachment 8493778 [details] [review] > Gaia PR > > Code seems fine to me semantically, though I feel like we may be masking the > possibility of detecting reflows for a real client in the future. Yes :/ Well only statusbar related. Don't know how we'll be able to do reliable reflow testing on the statusbar (mainly because of the clock), but happy to cover the window manager in the meantime :)
Would it be possible to freeze the clock "à la" sinon fake timers?
Comment on attachment 8493778 [details] [review] Gaia PR Ha! The test failed during the last try-run, back to the drawing board, clearing the r? flag.
Attachment #8493778 - Flags: review+
Comment on attachment 8493778 [details] [review] Gaia PR Looks better, I've simplified the test to work with 2 apps instead of 3 (without losing coverage) in order to make the setup lighter. The 60 try runs  look very good, wonder if I should trigger more.  https://tbpl.mozilla.org/?rev=38777554289972bdee9308b3c8ea7dbb0bc1a3e1&tree=Gaia-Try
Comment on attachment 8493778 [details] [review] Gaia PR Thanks for running this so many times. It does seem like we have quite a few intermittents (though many due to the socket connection problem). I unfortunately did see one failure related to this test here: https://tbpl.mozilla.org/php/getParsedLog.php?id=49039814&tree=Gaia-Try#error2 One option might be to split up these test cases into separate files. Then we could probably bring the left <-> right swiping tests back quickly. What do you think?
Yes, enabling the vertical swipe test is a bit outside of the scope here. Just saw that the blocking bug mentioned in the comment was fixed so I turned it on :) I'm giving it one shot (to keep it enabled) and if it fails I'll make a version of the patch with only the basic test.
Created attachment 8498874 [details] [review] New gaia PR
Comment on attachment 8498874 [details] [review] New gaia PR Awesome. Let's see what this does. Thanks!
Attachment #8498874 - Flags: review?(kgrandon) → review+
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Removing leave-open keyword from resolved bugs, per :sylvestre.
You need to log in before you can comment on or make changes to this bug.