Comment on attachment 8464227 [details] [review] Github pull request This is a first pass at some cleanup. The main goal of this is to combine home search bar and rocketbar.js together to remove some duplicated code. There is more to do here, but I didn't want to make this patch much bigger. Once this lands we can do some more cleanup. Flagging Alive and Vivien for review now. I hate to overload you guys though, so if you want, feel free to pass this off to Dale or someone else if you need to. Thanks!
Comment on attachment 8464227 [details] [review] Github pull request Seems reasonable to merge them.
Attachment #8464227 - Flags: review?(21) → review+
Comment on attachment 8464227 [details] [review] Github pull request Thanks. I'll land this first, and cause you some rebase conflicts for the transition if that's ok.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S1 (1aug)
You need to log in before you can comment on or make changes to this bug.