Closed Bug 1045758 Opened 7 years ago Closed 7 years ago

Combine home search and rocketbar

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S1 (1aug)

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
vingtetun
: review+
Details | Review
No description provided.
Blocks: 1045731
Attached file Github pull request
Comment on attachment 8464227 [details] [review]
Github pull request

This is a first pass at some cleanup. The main goal of this is to combine home search bar and rocketbar.js together to remove some duplicated code.

There is more to do here, but I didn't want to make this patch much bigger. Once this lands we can do some more cleanup.

Flagging Alive and Vivien for review now. I hate to overload you guys though, so if you want, feel free to pass this off to Dale or someone else if you need to. Thanks!
Attachment #8464227 - Flags: review?(alive)
Attachment #8464227 - Flags: review?(21)
Comment on attachment 8464227 [details] [review]
Github pull request

Seems reasonable to merge them.
Attachment #8464227 - Flags: review?(21) → review+
Comment on attachment 8464227 [details] [review]
Github pull request

Thanks. I'll land this first, and cause you some rebase conflicts for the transition if that's ok.
Attachment #8464227 - Flags: review?(alive)
Master: https://github.com/mozilla-b2g/gaia/commit/5f5e9ca5688b278dfa8443a647ad98c6b7621919
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S1 (1aug)
Depends on: 1048991
You need to log in before you can comment on or make changes to this bug.