Combine home search and rocketbar

RESOLVED FIXED in 2.1 S1 (1aug)

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

unspecified
2.1 S1 (1aug)
x86
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [systemsfe])

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

4 years ago
Blocks: 1045731
(Assignee)

Comment 1

4 years ago
Created attachment 8464227 [details] [review]
Github pull request
(Assignee)

Comment 2

4 years ago
Comment on attachment 8464227 [details] [review]
Github pull request

This is a first pass at some cleanup. The main goal of this is to combine home search bar and rocketbar.js together to remove some duplicated code.

There is more to do here, but I didn't want to make this patch much bigger. Once this lands we can do some more cleanup.

Flagging Alive and Vivien for review now. I hate to overload you guys though, so if you want, feel free to pass this off to Dale or someone else if you need to. Thanks!
Attachment #8464227 - Flags: review?(alive)
Attachment #8464227 - Flags: review?(21)
Comment on attachment 8464227 [details] [review]
Github pull request

Seems reasonable to merge them.
Attachment #8464227 - Flags: review?(21) → review+
(Assignee)

Comment 4

4 years ago
Comment on attachment 8464227 [details] [review]
Github pull request

Thanks. I'll land this first, and cause you some rebase conflicts for the transition if that's ok.
Attachment #8464227 - Flags: review?(alive)
(Assignee)

Comment 5

4 years ago
Master: https://github.com/mozilla-b2g/gaia/commit/5f5e9ca5688b278dfa8443a647ad98c6b7621919
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S1 (1aug)
(Assignee)

Updated

4 years ago
Depends on: 1048991
You need to log in before you can comment on or make changes to this bug.