Closed Bug 1045769 Opened 5 years ago Closed 5 years ago

Adjust new tab whitespace: whitespace sizing, positioning of undo box

Categories

(Firefox :: New Tab Page, defect)

defect
Not set
Points:
3

Tracking

()

VERIFIED FIXED
Firefox 34
Iteration:
34.2
Tracking Status
firefox33 --- verified
firefox34 --- verified

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

Attachments

(5 files)

phlsa suggests that with the larger tiles, some of the whitespace around the edges / around the tiles / around the undo box should be adjusted. This might also suggest a movement of the undo box to be closer to the gear/customize button freeing up some of the extra padding that goes around the box.
Is this something we want? If so, where should the undo box move to? Anchored to the top-right right next to the gear with some padding? Any minimum white space between the top of the search and the bottom of the undo box?
Flags: needinfo?(athornburgh)
Blocks: 1036284
Points: --- → 3
Flags: firefox-backlog+
Notes from dcrobot:

Space above Search Bar = 35
Space below Search Bar = 70
Add 5 px spacing between Tiles and their Lables (i.e. "Amazon"), as well as 5 px between Tile rows
Flags: needinfo?(athornburgh)
Attached image before screenshot
Attached image after screenshot
The increase tile spacing basically uses up all the whitespace gained from moving the undo box from the top middle. This won't help with showing more rows in a given screen height, but it will help things not feel so cramped.
Attached patch v1Splinter Review
Moves undo to top left avoiding some alignment issues with the customize button now/later.
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #8472730 - Flags: review?(adw)
Comment on attachment 8472730 [details] [diff] [review]
v1

Review of attachment 8472730 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, this is much nicer for the common case where the undo container is hidden.
Attachment #8472730 - Flags: review?(adw) → review+
https://hg.mozilla.org/mozilla-central/rev/7545b8222ecb
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Iteration: --- → 34.2
QA Whiteboard: [qa?]
QA Whiteboard: [qa?] → [qa+]
QA Contact: cornel.ionce
While testing this on latest Nightly (build ID: 20140817030204) I've noticed that there still is a large white space between the undo box and the search bar compared to the "after" screenshot. Same for Ubuntu and Mac OS.

Is it ok to leave it like this? Should I file a separate bug?
Flags: needinfo?(edilee)
(In reply to Cornel Ionce [QA] from comment #9)
> that there still is a large white space between the undo box and the search
> bar compared to the "after" screenshot. Same for Ubuntu and Mac OS.
What happens if you shrink the window height? What's the closest you can get the undo box to the search box before a row of tiles disappears (causing the whitespace to then increase).
Flags: needinfo?(edilee)
That looks as designed.  The undo box is supposed to stick to the top left corner now, and the search box + tiles should be better vertically centered than before with respect to the top and bottom of the window, which they are in your screenshot.
If I shrink the window height then indeed the whitespace also shrinks along with it. The closest is shown in the attached screenshot and it seems ok.
Thank you!
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa+] → [qa!]
Blocks: 1057602
Uplift has been managed in bug 1057602
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:33.0) Gecko/20100101 Firefox/33.0
Mozilla/5.0 (X11; Linux i686; rv:33.0) Gecko/20100101 Firefox/33.0

Verified fixed on Windows 7 64bit, Mac OS X 10.8.5 and Ubuntu 14.04 32bit using latest Aurora, build ID: 20140828004002.
Depends on: 1083831
You need to log in before you can comment on or make changes to this bug.