1045819 - Search bar overlaps suggestions and results on gingerbread

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Search Activity, defect, P1)

Comment 1

[:Margaret Leibovic]

Attachment: Specify gravity on fragments for margin to take effect on gingerbread

PR here: https://github.com/ericedens/FirefoxSearch/pull/37

Comment 2

[Eric Edens [:eedens]]

Comment on attachment 8464246 [details] [diff] [review]
Specify gravity on fragments for margin to take effect on gingerbread

Review of attachment 8464246 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Comment 3

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/22f6f3a432a0

The PR for bug 1042189 is based on top of this, so you can just merge that PR to get both commits.

Comment 4

[:Margaret Leibovic]

https://github.com/ericedens/FirefoxSearch/commit/66ee488bcf1b9968c7d8f8d71d011272802a2af6

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/22f6f3a432a0

Comment 6

[Flaviu Cos]

Verified as fixed in build 34.0a1 (2014-08-07);
Device: Samsung Galaxy R (Android 2.3.4).