unified version of test_swap_protocol.js is disabled without a reason

RESOLVED FIXED in mozilla34

Status

()

Toolkit
Places
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mak, Assigned: mak)

Tracking

Trunk
mozilla34
Points:
2
Bug Flags:
firefox-backlog +
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
sounds like I wrongly landed this test disabled. and it's failing so there might be a bug here.
(Assignee)

Comment 1

3 years ago
Created attachment 8464622 [details] [diff] [review]
disabled.diff
Attachment #8464622 - Flags: review?(ttaubert)
(Assignee)

Comment 2

3 years ago
Marco please add to the current iteration
Points: --- → 2
Flags: needinfo?(mmucci)
Flags: firefox-backlog+
(Assignee)

Updated

3 years ago
QA Whiteboard: [qa-]
Added to Iteration 34.1.
Status: NEW → ASSIGNED
Iteration: --- → 34.1
Flags: needinfo?(mmucci)
Comment on attachment 8464622 [details] [diff] [review]
disabled.diff

Review of attachment 8464622 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/places/tests/unifiedcomplete/test_swap_protocol.js
@@ +42,1 @@
>    Services.prefs.setBoolPref("browser.urlbar.autoFill", "false");

Shouldn't we call clearUserPref() somewhere when the test ends? Is that done in cleanup() somehow? Couldn't find right away.
Attachment #8464622 - Flags: review?(ttaubert) → review+
(Assignee)

Comment 5

3 years ago
yes, cleanup clears the prefs
(Assignee)

Comment 6

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/6e3a195c264e
Target Milestone: --- → mozilla34
https://hg.mozilla.org/mozilla-central/rev/6e3a195c264e
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.