1046062 - unified version of test_swap_protocol.js is disabled without a reason

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak]]

sounds like I wrongly landed this test disabled. and it's failing so there might be a bug here.

Comment 1

[Marco Bonardo [:mak]]

Attachment: disabled.diff

Comment 2

[Marco Bonardo [:mak]]

Marco please add to the current iteration

Comment 3

[Marco Mucci [:MarcoM]]

Added to Iteration 34.1.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8464622 [details] [diff] [review]
disabled.diff

Review of attachment 8464622 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/places/tests/unifiedcomplete/test_swap_protocol.js
@@ +42,1 @@
>    Services.prefs.setBoolPref("browser.urlbar.autoFill", "false");

Shouldn't we call clearUserPref() somewhere when the test ends? Is that done in cleanup() somehow? Couldn't find right away.

Comment 5

[Marco Bonardo [:mak]]

yes, cleanup clears the prefs

Comment 6

[Marco Bonardo [:mak]]

https://hg.mozilla.org/integration/fx-team/rev/6e3a195c264e

Comment 7

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/mozilla-central/rev/6e3a195c264e