1046140 - domUtils.getSubpropertiesForCSSProperty("--foo") returns a huge object

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Paul Rouget [:paul]]

This code:
Cc["@mozilla.org/inspector/dom-utils;1"].getService(Ci.inIDOMUtils).getSubpropertiesForCSSProperty("--foo")

... returns 6398 sub properties. This makes the devtools go crazy when inspecting variables.

Comment 1

[Paul Rouget [:paul]]

Attachment: attempt

I guess that might work...

Comment 2

[Paul Rouget [:paul]]

Yep.

Who could review that?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Can we add a test?  Just running that line from comment 0 in a debug build shows that something is obviously wrong, since it fails a NS_ABORT_IF_FALSE in nsCSSProps::IsShorthand.

Comment 4

[Paul Rouget [:paul]]

Attachment: v1

Comment 5

[Paul Rouget [:paul]]

https://tbpl.mozilla.org/?tree=Try&rev=db128a3e211d

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8464737 [details] [diff] [review]
v1

r=me

Comment 7

[Boris Zbarsky [:bzbarsky]]

Please talk to Cameron about where this needs to be backported to.

Comment 8

[Paul Rouget [:paul]]

(In reply to Boris Zbarsky [:bz] from comment #7)
> Please talk to Cameron about where this needs to be backported to.

Devtools code started using getSubpropertiesForCSSProperty with CSS variable names only in Firefox 34, and only devtools use this method. So we don't have to backport this code.

Cameron, do you think we should ask for beta and/or aurora approval?

Comment 9

[Cameron McCormack (:heycam)]

Can extensions use things on inDOMUtils?  If so, we should backport to Aurora just in case someone tries to use it.

Comment 10

[Boris Zbarsky [:bzbarsky]]

> Can extensions use things on inDOMUtils? 

Absolutely.

Comment 11

[Cameron McCormack (:heycam)]

[Tracking Requested - why for this release]: Extensions can call code that triggers an NS_ABORT_IF_FALSE.  Although extensions aren't known to be using this API yet, better close off the bug before they do.

Comment 12

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/367a559c6b3b

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/367a559c6b3b

Comment 14

[Cameron McCormack (:heycam)]

Comment on attachment 8464737 [details] [diff] [review]
v1

Approval Request Comment
[Feature/regressing bug #]: bug 1006595
[User impact if declined]: Extensions can call code that triggers an NS_ABORT_IF_FALSE.
[Describe test coverage new/current, TBPL]: Automated test added; patch has just landed on mozilla-central.
[Risks and why]: Low, this just causes the method to throw an exception.
[String/UUID change made/needed]: N/A

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2a4ae7cd64a1