1046212 - Rename tabspanel to tabsui

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Lucas Rocha (:lucasr)]

Or maybe just 'tabs'? The tabspanel package will also contain the new tabstrip UI code. Let's make the package name a bit more general around the tabs UI.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Rename tabspanel package to simply tabs (r=mcomella)

Comment 2

[Lucas Rocha (:lucasr)]

Comment on attachment 8467817 [details] [diff] [review]
Rename tabspanel package to simply tabs (r=mcomella)

Decide to go with just 'tabs'. The 'ui' suffix would just be redundant noise. Yes, we have Tabs/Tab in the base package but this is not going to confuse anyone I think.

Comment 3

[Lucas Rocha (:lucasr)]

Probably worth mentioning that I'll land this straight in m-c.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Comment on attachment 8467817 [details] [diff] [review]
Rename tabspanel package to simply tabs (r=mcomella)

Review of attachment 8467817 [details] [diff] [review]:
-----------------------------------------------------------------

I kind of prefer `tabsui` to make the difference between Tab/Tabs.java and these other classes obvious, but I could go either way.

Comment 5

[Lucas Rocha (:lucasr)]

(In reply to Michael Comella (:mcomella) from comment #4)
> Comment on attachment 8467817 [details] [diff] [review]
> Rename tabspanel package to simply tabs (r=mcomella)
> 
> Review of attachment 8467817 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I kind of prefer `tabsui` to make the difference between Tab/Tabs.java and
> these other classes obvious, but I could go either way.

Which makes me think that maybe we should move Tab/Tabs.java to the 'tabs' package...

https://hg.mozilla.org/integration/fx-team/rev/1b9ed8a49032

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1b9ed8a49032