Closed
Bug 1046212
Opened 11 years ago
Closed 11 years ago
Rename tabspanel to tabsui
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 34
People
(Reporter: lucasr, Assigned: lucasr)
References
Details
Attachments
(1 file)
|
22.36 KB,
patch
|
mcomella
:
review+
|
Details | Diff | Splinter Review |
Or maybe just 'tabs'? The tabspanel package will also contain the new tabstrip UI code. Let's make the package name a bit more general around the tabs UI.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8467817 [details] [diff] [review]
Rename tabspanel package to simply tabs (r=mcomella)
Decide to go with just 'tabs'. The 'ui' suffix would just be redundant noise. Yes, we have Tabs/Tab in the base package but this is not going to confuse anyone I think.
Attachment #8467817 -
Flags: review?(michael.l.comella)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Probably worth mentioning that I'll land this straight in m-c.
Comment on attachment 8467817 [details] [diff] [review]
Rename tabspanel package to simply tabs (r=mcomella)
Review of attachment 8467817 [details] [diff] [review]:
-----------------------------------------------------------------
I kind of prefer `tabsui` to make the difference between Tab/Tabs.java and these other classes obvious, but I could go either way.
Attachment #8467817 -
Flags: review?(michael.l.comella) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
(In reply to Michael Comella (:mcomella) from comment #4)
> Comment on attachment 8467817 [details] [diff] [review]
> Rename tabspanel package to simply tabs (r=mcomella)
>
> Review of attachment 8467817 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> I kind of prefer `tabsui` to make the difference between Tab/Tabs.java and
> these other classes obvious, but I could go either way.
Which makes me think that maybe we should move Tab/Tabs.java to the 'tabs' package...
https://hg.mozilla.org/integration/fx-team/rev/1b9ed8a49032
|
||
Comment 6•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
|
|
Assignee | |
Updated•11 years ago
|
Blocks: new-tablet-v1
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•