Closed Bug 1046215 Opened 6 years ago Closed 6 years ago

Update Home Feeds add-on to address feedback requests

Categories

(Firefox for Android :: General, defect)

32 Branch
ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
fennec + ---

People

(Reporter: krudnitski, Assigned: Margaret)

References

(Blocks 1 open bug)

Details

When adding a feed to my home screen panels, I tap on the icon and it says 'Subscribe with' and it lists 'Firefox homepage' as an option.

I'm not sure this feels right. To me, it would be 'Firefox home page' or simply 'Firefox'. If we were *adding* to the Firefox home screens as an additional panel, I would probably lean towards something like 'Firefox home screen panel' or 'Firefox home panel', but since we're 'subscribing', I think you would subscribe via Firefox.

Would just like to lock down the wording here for consistency because it really gave me pause looking at this current wording.
Ian, do you have any thoughts about how we should update this?

I'm tempted to make the add-on not even let you choose between Yahoo! and a home panel when you hit the icon (just have the icon add a home panel), but we would still want to add an option to the "Subscribe" menu.

Potential mentees, if you're looking to contribute, the code for this is on github:
https://github.com/leibovic/fennec_rss/
Mentor: margaret.leibovic
Flags: needinfo?(ibarlow)
Summary: Adding a web feed to my home screen panels → Reword "Firefox homepage" option in Home Feeds add-on
Whiteboard: [lang=js]
tracking-fennec: ? → +
Blocks: 1046913
(In reply to :Margaret Leibovic from comment #1)
> Ian, do you have any thoughts about how we should update this?
> 
> I'm tempted to make the add-on not even let you choose between Yahoo! and a
> home panel when you hit the icon (just have the icon add a home panel)

+1 

> but we would still want to add an option to the "Subscribe" menu.

I rather like Karen's suggestion of just saying "Firefox" instead of "Firefox homepage". 

Also, I'm curious if there is any way to make Firefox the first option in the menu, instead of Yahoo?
Flags: needinfo?(ibarlow)
+1 to "Firefox"
(In reply to Ian Barlow (:ibarlow) from comment #2)
> (In reply to :Margaret Leibovic from comment #1)
> > Ian, do you have any thoughts about how we should update this?
> > 
> > I'm tempted to make the add-on not even let you choose between Yahoo! and a
> > home panel when you hit the icon (just have the icon add a home panel)
> 
> +1 
> 
> > but we would still want to add an option to the "Subscribe" menu.
> 
> I rather like Karen's suggestion of just saying "Firefox" instead of
> "Firefox homepage". 
> 
> Also, I'm curious if there is any way to make Firefox the first option in
> the menu, instead of Yahoo?

My add-on is already futzing around with this menu, so anything is possible :)

I'm going to try setting aside some time to revisit my hub add-ons, and I can work on this bug as part of that.
Assignee: nobody → margaret.leibovic
Mentor: margaret.leibovic
Whiteboard: [lang=js]
(In reply to :Margaret Leibovic from comment #4)
> I'm going to try setting aside some time to revisit my hub add-ons, and I
> can work on this bug as part of that.

I'm looking to clean up some of these visuals and interactions around panels too! (starting with bug 1052933) let me know if you'd like to work on some of this together :)
(In reply to Anthony Lam (:antlam) from comment #5)
> (In reply to :Margaret Leibovic from comment #4)
> > I'm going to try setting aside some time to revisit my hub add-ons, and I
> > can work on this bug as part of that.
> 
> I'm looking to clean up some of these visuals and interactions around panels
> too! (starting with bug 1052933) let me know if you'd like to work on some
> of this together :)

I'm trying to keep the scope of this bug small. I'm just going to update the Home Feeds add-on to fix feedback I've gotten about the interactions and release a version 0.9. I'm also going to try to update the add-on listing to make it more searchable.

Main changes I want to make:

* Reword "Firefox homepage" option in "Subscribe" menu to just "Firefox"
* Make RSS icon in toolbar directly add feed to about:home, rather than opening the menu to let you choose between "My Yahoo!" and "Firefox"
* Update pref name for pref used to store home feeds (my add-on didn't get full review because it doesn't use an "extensions" prefix)

Anyone else in this bug have any other requests?

Pascal, this is going to change a string in my add-on. Should I update entity names like I would for strings in Firefox? The problem with this is that if the entity doesn't exist in the new locale the add-on will break in that locale. However, since this change is "Firefox homepage" -> "Firefox", I could actually just pull in brand.properties and use that string instead. This means that the options will be "Nighly" or "Aurora" in those channels, but I think that's fine.
Flags: needinfo?(pascalc)
Summary: Reword "Firefox homepage" option in Home Feeds add-on → Update Home Feeds add-on to address feedback requests
Pascal is on PTO until Sep 1st.

I think he stored translations in a .lang file, but I don't know where the actual add-on lives (github?) or the process he used for conversion
http://l10n.mozilla-community.org/~pascalc/langchecker/?locale=all&website=7&file=homefeeds.lang

These .lang file don't have string IDs, so we actually only need the new string content. Only the string "Firefox homepage" will change, or also "Added to Firefox homepage"? If needed I can definitely add those strings to .lang files
(In reply to Francesco Lodolo [:flod] from comment #7)
> Pascal is on PTO until Sep 1st.
> 
> I think he stored translations in a .lang file, but I don't know where the
> actual add-on lives (github?) or the process he used for conversion
> http://l10n.mozilla-community.org/~pascalc/langchecker/
> ?locale=all&website=7&file=homefeeds.lang
> 
> These .lang file don't have string IDs, so we actually only need the new
> string content. Only the string "Firefox homepage" will change, or also
> "Added to Firefox homepage"? If needed I can definitely add those strings to
> .lang files

I just made the changes. I replaced the "Firefox homepage" string with the shortBrandName string from branding.properties, so we don't need to worry about that, but I did update the "Added to Firefox homepage" string as well.

I added a try/catch where I use this string to fall back to the old string if a locale isn't updated, but it would be good to update the other locales. Also, I noticed that there is a "This feed is already on your homepage" string in en-US that I added later, and I must not have notified pascal about updating the string.

Here is the current set of strings:
https://github.com/leibovic/fennec_rss/blob/master/locale/en-US/feeds.properties

Here's also an update version of the add-on to test:
http://people.mozilla.org/~mleibovic/homefeeds.0.9.xpi

Aaron, could you help me test this? 

The changes I made are:

* Tapping on the RSS icon directly adds the feed to the home page (but will still prompt user to choose the feed if there are multiple on the page)
* Page->Subscribe to Page menu item now says "Firefox", instead of "Firefox homepage" (or whatever the product brand name is)
* "Firefox" option is listed first in the list
* Pref used to store subscribed feeds is updated to be add-on review friendly (I added code to migrate the existing pref, and I tested an upgrade flow, but I want to be sure not to break existing add-on users)
Flags: needinfo?(aaron.train)
Extracted new strings in r131260. I'll look later this week if I can find how he did the conversion.
flod: https://github.com/pascalchevrel/addons_l10n

Worked well last time :)

I am on PTO until end of the month with sporadic internet access, cheers.
Flags: needinfo?(pascalc)
I ran into bug 1055212, but otherwise couldn't find any other problems
Flags: needinfo?(aaron.train)
I just uploaded version 0.9 to AMO and updated the add-on listing:
https://addons.mozilla.org/en-US/android/addon/home-feeds/

I updated the screenshots because they were out of date, and I also added tags to the add-on description to try to make it easier to find when searching.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Unfortunately I didn't get any more updates from other locales. I'll open PRs as soon as I see them.
You need to log in before you can comment on or make changes to this bug.