1046226 - Improve error message when using a URL with an incorrect repo name

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Ed Morley [:emorley]]

Visiting:
https://treeherder.mozilla.org/ui/#/jobs?repo=foo

Results in:
"Error retrieving job data!"

Rather than:
"Unknown repo!"

This makes things like bug 1046225 harder to figure out.

Comment 1

[Ed Morley [:emorley]]

It looks like unfortunately this part:
https://github.com/mozilla/treeherder-ui/commit/08cc4f1a6603b5fbf353091d6045166144f732e5#diff-84193e569f1b29f0ab46ad40005626f8R59

of bug 1065541 doesn't quite work.

eg try:
http://treeherder-dev.allizom.org/ui/#/jobs?repo=foo

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Ed Morley [:edmorley] from comment #1)
> It looks like unfortunately this part:
> https://github.com/mozilla/treeherder-ui/commit/
> 08cc4f1a6603b5fbf353091d6045166144f732e5#diff-
> 84193e569f1b29f0ab46ad40005626f8R59
> 
> of bug 1065541 doesn't quite work.
> 
> eg try:
> http://treeherder-dev.allizom.org/ui/#/jobs?repo=foo

Huh. I think I must've made a copy/paste fail somewhere in there.
The conditions for showing the unknown repo error are:
"result_sets.length == 0 && !isLoadingRsBatch.appending && !isLoadingJobs &&     !locationHasSearchParam('revision') && !locationHasSearchParam('repo') && !currentRepo.url

I think the "!locationHasSearchParam('repo')" should be "locationHasSearchParam('repo')" without the "!" at the beginning.

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Fix the error condition

This seems to work locally.

Comment 4

[Ed Morley [:emorley]]

Comment on attachment 8490180 [details] [review]
Fix the error condition

lgtm - thank you :-)

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/5cd5d9ea697faf6022210f79482d2344ae119cfd
Bug 1046226 - Fix unknown repository condition

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/4aff201600349f7b848e2de4358641165662de20
Bug 1046226 - Fix unknown repository condition