1046289 - [NFC] Wrong method called to make a connect after BT pairing

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Kamil Leszczuk [:kamituel]]

In nfc_handover_manager.js, after pairing with BT device, the this.doConnect() is being called, while it should be this._doConnect().

This is a bug I (unfortunately) introduced when I was working on bug 948823.

Comment 1

[Kamil Leszczuk [:kamituel]]

Attachment: Pull request

Fix and unit test to ensure this code path is covered.

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8464951 [details] [review]
Pull request

Simple change and it looks good. However, I notice that there is no CI result. You may wait or re-trigger it and then land the code.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/74591a3ba97fc008e63dba7d783746aff0df40b3

Comment 5

[Kamil Leszczuk [:kamituel]]

Comment on attachment 8464951 [details] [review]
Pull request

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]

[Bug caused by] (feature/regressing bug #):
948823

[User impact] if declined: 
NFC BT pairing issues

[Testing completed]: 
yes

[Risk to taking this patch] (and alternatives if risky): 
see user impact

[String changes made]: 
no

Comment 7

[Jason Smith [:jsmith]]

[Blocking Requested - why for this release]:

Carry over of the blocking nomination from the dupe.

Comment 8

[bhavana bajaj [:bajaj]]

Comment on attachment 8464951 [details] [review]
Pull request

Given this is already blocking and will autoland, clearing the approval request here.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/6ef1f15ce74ef90460c50aa830c04c9676564d1d