Closed Bug 1046301 Opened 6 years ago Closed 6 years ago

Apple PlatformMediaDecoder should call DrainComplete

Categories

(Core :: Audio/Video, defect)

x86_64
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(2 files)

Anthony says fixing bug 1039128 involved a new DrainComplete callback method, which all the decoders should call. See the related changes in WMFMediaDataDecoder.cpp and test with the video in that bug.
Unfortunately even with both of these patches, I still see the 'Decemeber' title at the end of https://people.mozilla.org/~cpearce/avatar.mp4 rather than a black frame.
Attachment #8465064 - Flags: review?(cpearce)
Attachment #8465064 - Flags: review?(cpearce) → review+
Attachment #8465063 - Flags: review?(cpearce) → review+
Depends on: 941296
With the changes in bug 1047188, I get to the end of the avatar trailer.
https://hg.mozilla.org/mozilla-central/rev/fd7e43357416
https://hg.mozilla.org/mozilla-central/rev/b2f257bcaff9
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.