Closed
Bug 1046301
Opened 10 years ago
Closed 10 years ago
Apple PlatformMediaDecoder should call DrainComplete
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: rillian, Assigned: rillian)
References
Details
Attachments
(2 files)
|
2.42 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
|
690 bytes,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
Anthony says fixing bug 1039128 involved a new DrainComplete callback method, which all the decoders should call. See the related changes in WMFMediaDataDecoder.cpp and test with the video in that bug.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8465063 -
Flags: review?(cpearce)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Unfortunately even with both of these patches, I still see the 'Decemeber' title at the end of https://people.mozilla.org/~cpearce/avatar.mp4 rather than a black frame.
Attachment #8465064 -
Flags: review?(cpearce)
|
||
Updated•10 years ago
|
Attachment #8465064 -
Flags: review?(cpearce) → review+
|
|
||
Updated•10 years ago
|
Attachment #8465063 -
Flags: review?(cpearce) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd7e43357416 https://hg.mozilla.org/integration/mozilla-inbound/rev/b2f257bcaff9
|
|
Assignee | |
Comment 4•10 years ago
|
||
With the changes in bug 1047188, I get to the end of the avatar trailer.
|
||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fd7e43357416 https://hg.mozilla.org/mozilla-central/rev/b2f257bcaff9
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•