1046498 - [Text Selection] Selection carets is jumpy when dragging caret.

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: test.html

In the multi-line textarea, when we drag selection caret to adjust selection range, the carets is jumpy when we drag in the between of two lines.

Comment 1

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Constrain frame to anchor subtree when dragging selection caret.

I found that we'll select background frame when the cursor in the between of two lines and it causes jumpy. So I constrain frame to selction's anchor subtree.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Comment on attachment 8467664 [details] [diff] [review]
Constrain frame to anchor subtree when dragging selection caret.

Review of attachment 8467664 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/SelectionCarets.cpp
@@ +616,5 @@
> +  nsIFrame* caretFocusFrame = GetCaretFocusFrame();
> +  nsRefPtr<nsFrameSelection> fs = caretFocusFrame->GetFrameSelection();
> +
> +  nsresult result;
> +  nsIFrame *newFrame = 0;

Nit: nsIFrame* newFrame = nullptr;

Comment 3

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Constrain frame to anchor subtree when dragging selection caret. v2 (carry r+: roc)

Update to address comment.

Try run:  https://tbpl.mozilla.org/?tree=Try&rev=5439744d132f

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/596bd716d4f8

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/596bd716d4f8