Closed Bug 1046498 Opened 6 years ago Closed 6 years ago

[Text Selection] Selection carets is jumpy when dragging caret.

Categories

(Core :: DOM: Selection, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: mtseng, Assigned: mtseng)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached file test.html
In the multi-line textarea, when we drag selection caret to adjust selection range, the carets is jumpy when we drag in the between of two lines.
I found that we'll select background frame when the cursor in the between of two lines and it causes jumpy. So I constrain frame to selction's anchor subtree.
Assignee: nobody → mtseng
Status: NEW → ASSIGNED
Attachment #8467664 - Flags: review?(roc)
Comment on attachment 8467664 [details] [diff] [review]
Constrain frame to anchor subtree when dragging selection caret.

Review of attachment 8467664 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/SelectionCarets.cpp
@@ +616,5 @@
> +  nsIFrame* caretFocusFrame = GetCaretFocusFrame();
> +  nsRefPtr<nsFrameSelection> fs = caretFocusFrame->GetFrameSelection();
> +
> +  nsresult result;
> +  nsIFrame *newFrame = 0;

Nit: nsIFrame* newFrame = nullptr;
https://hg.mozilla.org/mozilla-central/rev/596bd716d4f8
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.