1046505 - [Text Selection] Implement temporary shortcut for utility bubble.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Quote from spec page 7 [1],
"If the user taps the edit field after copy or cut, the handle will pop up with the utility bubble which shows “paste” for further edit. This is a temporary shortcut and only appears after the action “copy/cut”. In this use case, the utility bubble will time-out after 3 secs if no action is taken. Once user taps “Paste”, the shortcut will not appear again by tapping edit field."

"If text is not pasted immediately after copy/cut, the text will be viewed as pasted after 15 seconds (count starting from the moment when there's no action at all), and there will be no paste shortcut pop up when tapping on edit field"

In other words, we must implement following features for this spec.
1. Tell embedder we are showing temporary shortcut or not based on copy/cut has been performed or not.
2. After copy/cut and there is no action for 15 seconds, disable temporary shortcut.

[1] https://bug921965.bugzilla.mozilla.org/attachment.cgi?id=8448605

Comment 1

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: bug1046505

Comment 2

[(no longer active)]

Comment on attachment 8466004 [details] [diff] [review]
bug1046505

Review of attachment 8466004 [details] [diff] [review]:
-----------------------------------------------------------------

We shouldn't cripple the API like this, the code that uses the selectionchange event should be responsible for implementing this behavior.

Comment 4

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: bug1046505 v2

Once bug 1020802 is landed, we can move all temporary shortcut logic to gaia by applying this patch.

Comment 5

[(no longer active)]

(In reply to Morris Tseng [:mtseng] from comment #4)
> Created attachment 8469027 [details] [diff] [review]
> bug1046505 v2
> 
> Once bug 1020802 is landed, we can move all temporary shortcut logic to gaia
> by applying this patch.

Great!

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

waiting for test

Comment 7

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8475808 [details] [review]
PR to master

Hi Alive,
could you review this patch? 
Thanks.

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks,
master: https://github.com/mozilla-b2g/gaia/commit/7e2165cbc81d32188a2a7cf0f4bac6a61c7f42fc