1046509 - [Flatfish] Lockscreen should not be disabled.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Settings, defect, P2)

Description

[Caspy7]

The default for builds is currently to disable the lockscreen. 
This means that the screen does not shut off...ever (on its own).  This is a problem for several reasons, but either way, it should not be the default.

Comment 1

[Caspy7]

Joe, including you as I expect this is a build option for the vendor.

Comment 2

[Sherman Chen [:chens] (inactive)]

This is normal when we set DEVICE_DEBUG=1, the purpose of DEVICE_DEBUG=1 is to provide a developer friendly environment so it will do following things: disables screen lock and timeout on the device, and enables debugging with the ADB tool.

If screen doesn't shut off becomes a problem, it always can be turn on in settings.

Comment 3

[Joe Cheng [:jcheng] (please needinfo)]

is it the same behavior for the phones such as the flame?
i feel that tablets should align with the phones. 

ni? William for further comments

Comment 4

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

This is something that is being brought up still.  Was this behavior changed for a specific reason? If so, why? Does this also apply to other devices?

Comment 5

[Caspy7]

Per my conversation with Asa, we do not want the DEVICE_DEBUG=1 option for a few reasons, one being consistency with other devices (and documentation).

This option was turned on in bug 1034941 to enable 'ADB and DevTools' by default for usb debugging.

If there is a way that it's possible to have that without the lockscreen and screen timeout effects of DEVICE_DEBUG=1 that would be welcome.

Comment 6

[Joe Cheng [:jcheng] (please needinfo)]

hi Danny, is it something that we can do to remove the DEVICE_DEBUG=1 option for Flatfish? Thanks

Comment 7

[Danny Liang [:dliang]]

I checked the default and latest build in flatfish device, they did have lock screen.
I also checked the build flag in code base of flatfish, we don't set DEVICE_DEBUG=1.

Hi Caspy7, may I know what's the default build you used?

Comment 8

[Caspy7]

Hrm. :-/

I currently have a build dated 8-21 and the lockscreen and screen timeout are disabled (indicating DEVICE_DEBUG=1). I obtained it from the vendor here: https://www.dropbox.com/sh/b2py1btcwstqldl/AABblbq_csa1IHQwdvLdfptTa

Notably they build early morning Taiwan time so it's still 8-20 for most everyone else.  The Git Commit Info says 2014-08-20 15:21:10.

Currently there is an problem and all builds after 8-21 are broken (see the build status page here: https://etherpad.mozilla.org/CmJbD8V0QX ). 
I can leave the ni? and update once we get another working build. 
Anyone else is, of course, welcome to do the same if they have a flatfish and this is resolved. I don't have the canon device, this has been affecting everyone with recent vendor builds.

Comment 9

[Caspy7]

I have now tested in the most recent build available from the vendor (8-29) and the behavior remains (no screen timeout, no lockscreen).
DEVICE_DEBUG=1 still seems to be set.

Comment 10

[Danny Liang [:dliang]]

Hi Iean, 
Could you help to check the build command of the build you released on dropbox, https://www.dropbox.com/sh/b2py1btcwstqldl/AABblbq_csa1IHQwdvLdfptTa.
It looks like your build command included DEVICE_DEBUG=1 and it caused there is no lockscreen as default.

Comment 11

[Iean Lin]

Hi Danny,

Yes, the "DEVICE_DEBUG=1" option was turned on by the bug-1034941, please let me know if this option should be turned off, thanks.

Comment 12

[Danny Liang [:dliang]]

hi Caspy,
If we remove DEVICE_DEBUG=1 in build command, lockscreen will be enabled and USB debugging will be disabled as default. Is this your expectation?

Comment 13

[Caspy7]

Prior to the command being added the lockscreen was enabled and USB Debugging was set to "ADB Only". It would be my expectation that the settings would return to this state.

Comment 14

[Danny Liang [:dliang]]

Caspy, 
Set REMOTE_DEBUGGER=1 can have lockscreen and USB debugging is "ADB Only".
If no concern, I will update the new build command to partner by replacing DEVICE_DEBUG=1 with REMOTE_DEBUGGER=1.

Comment 15

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

What we want here is that the lockscreen WILL be enabled by default. We also requested for Devtools and ADB to be turned on by default as well. I don't know if ADB Only is the best option for testing the tablets. If we can manage to keep the lockscreen enabled, ADB and Devtools enabled by default without causing too much chaos, that would be highly appreciated.

Comment 16

[BMO Automation]

Firefox OS is not being worked on