1046565 - Broken notification icon for low power mode

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[:gerard-majax]

STR:
 0. Battery dying, low power mode gets enabled
 1. Notification is sent for this

Expected:
 Notification in the utility tray has a valid icon

Actual:
 Icon is missing

battery_manager.js references System.png, which does not exists. It seems that icc_worker.js is also faulty for the same reason.

Comment 1

[:gerard-majax]

That's a regression from bug 1038167.

Comment 2

[Jason Smith [:jsmith]]

QA Wanted to get a screenshot.

Shouldn't this be nomed for 2.0, since the regressing patch landed on 2.0?

Comment 3

[:gerard-majax]

[Blocking Requested - why for this release]:

You're right.

Comment 4

[Jason Smith [:jsmith]]

Blocking for a bad regression with low power mode.

Comment 5

[Joshua Mitchell (Inactive)]

Attachment: 2014-07-31-10-30-58.png

Comment 6

[Joshua Mitchell (Inactive)]

screenshot added

Comment 7

[Aus Lacroix [:aus]]

*sigh* this just needs to refer to the *new* version of the icon. I can take care of it.

Comment 8

[Aus Lacroix [:aus]]

Pull request coming shortly...

Comment 9

[Aus Lacroix [:aus]]

Attachment: Pull Request - Add system.png 60x60 for notifications. Update references from System.png to system.png.

Comment 10

[Kevin Grandon :kgrandon]

I feel like this icon is more blurry than it should be =/  I'd rather hold off and get a fresh version converted from vector if that's ok.

Peter - are you able to get us a sharper icon at 60px size? https://github.com/mozilla-b2g/gaia/blob/master/apps/system/style/icons/system_84.png

Comment 11

[Kevin Grandon :kgrandon]

Comment on attachment 8465712 [details] [review]
Pull Request - Add system.png 60x60 for notifications. Update references from System.png to system.png.

I'll leave an early R+ here, but I want to wait to land until we get a sharper icon from Peter (or from a vector conversion if we have those).

Comment 12

[Aus Lacroix [:aus]]

Peter replied to me via email and it looks like he won't get to it until next week and suggested resizing from 284 for now (which is the icon I provided in my patch). I'll file a follow up to land the bestest version of the icon when it becomes available.

Commit (master): https://github.com/mozilla-b2g/gaia/commit/e43382bb9c0239e9062d69f4f9f9cf8e26d41a19

Commit (v2.0): https://github.com/mozilla-b2g/gaia/commit/7681c18524b50c9d3a760c876c222578e6e13eef

Fixed.

Comment 13

[Paladin]

This bug has been verified to fail on Flame 2.0,2.1
STR:
1) Battery dying.
2) Open Settings ->Battery.
3) Enable Power save mode.
**No notification in the utility tray

See attachment: Verify_video.3gp and logcat_flame_1622.txt
Reproducing rate: 5/5
Flame 2.0 build:
Gaia-Rev        856863962362030174bae4e03d59c3ebbc182473
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/e40fe21e37f1
Build-ID        20141207000206
Version         32.0
Flame2.1 build:
Gaia-Rev        38e17b0219cbc50a4ad6f51101898f89e513a552
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/8b92c4b8f59a
Build-ID        20141205001201
Version         34.0

Comment 14

[Paladin]

Attachment: Verify_video.3gp

Comment 15

[Paladin]

Attachment: logcat_flame_1622.txt

Comment 16

[William Hsu [:whsu]]

Add NI?whsu to follow up

Comment 17

[William Hsu [:whsu]]

(In reply to Paladin from comment #14)
> Created attachment 8533072 [details]
> Verify_video.3gp

Hi, Paladin,

Thanks for your help!
But, I found you didn't verify it correctly after I traced your reproduction steps via demo video.
Please follow steps below to verify it on v2.1 again.

STR:
 0. Battery dying ( Battery left < 25%)
 1. Go to setting -> Battery
 2. Select "25% battery left" and press "OK" button
 3. Drag and drop status bar and check notification.

Results should be same as attachment. (Power_Saving_Mode_20150106.png)

Comment 18

[William Hsu [:whsu]]

Verify this patch on v2.0 build.
As attachment (Power_Saving_Mode_20150106.png)

@ Build information:
 - Gaia-Rev        f76014fd2c7528493b90d759c68ec3070233d094
 - Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/aedeb9e38bb9
 - Build-ID        20150106000204
 - Version         32.0
 - Device-Name     flame
 - FW-Release      4.4.2
 - FW-Incremental  eng.cltbld.20150106.034857
 - FW-Date         Tue Jan  6 03:49:08 EST 2015
 - Bootloader      L1TC00011880

Comment 19

[William Hsu [:whsu]]

Attachment: Power_Saving_Mode_20150106.png

Comment 20

[Paladin]

Attachment: Power_save_0108.png

(In reply to William Hsu [:whsu] from comment #17)
> STR:
>  0. Battery dying ( Battery left < 25%)
>  1. Go to setting -> Battery
>  2. Select "25% battery left" and press "OK" button
>  3. Drag and drop status bar and check notification.
> 
> Results should be same as attachment. (Power_Saving_Mode_20150106.png)

According to the steps in comment #17, This issue has been verified successfully on Flame 2.0/2.1
See Power_save_0108.png

Flame 2.0 build:
Gaia-Rev        f76014fd2c7528493b90d759c68ec3070233d094
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/53ff92e647a0
Build-ID        20150107000201
Version         32.0
---------------------------
Flame 2.1 build:
Gaia-Rev        b04a8cb7b2482e0a44e6702b48c42283a00b5b1e
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/99cea2c818f6
Build-ID        20150107001244
Version         34.0