1038167 - Need an icon for Smart Collection in App permissions screen in Settings

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Johan Lorenzo [:jlorenzo]]

Attachment: App permissions - screenshot

STR
1. Go to settings
2. Go to app permissions

Actual result
The default icon is still used.

Expected result
As we have different permissions between Homescreen and Smart Collection, we should display a more explicit icon.

Comment 1

[Johan Lorenzo [:jlorenzo]]

We cannot ship with that kind of missing icon

Comment 2

[Johan Lorenzo [:jlorenzo]]

(In reply to Johan Lorenzo [:jlorenzo] from comment #1)
We cannot ship with that kind of missing icon, can we?

Comment 3

[Gregor Wagner [:gwagner]]

Do we have UX/visual for this?

Comment 4

[Stephany Wilkes]

Flagging Peter since we cannot ship with a missing icon.

Comment 5

[Kevin Grandon :kgrandon]

Might want to track it in another bug, but we will also need an icon for the "Search Results" app. Currently the default icon is even worse than the default smart collections icon, I think it's because we copied the template app for that one.

Comment 6

[Johan Lorenzo [:jlorenzo]]

(In reply to Kevin Grandon :kgrandon from comment #5)
> Might want to track it in another bug, but we will also need an icon for the
> "Search Results" app.
Already filed ;)

Comment 7

[Kevin Grandon :kgrandon]

Assigning this to Peter to create the icon, then I'll take it and implement once we have assets.

Comment 8

[Aus Lacroix [:aus]]

Peter, feel free to assign this to me once you've made the icon.

Comment 9

[Peter La]

Attachment: AppPermissionsIcons-20140529.zip

Hi Kevin,

As we spoke about this morning, I'm uploading new icons for not only the Smart Collections in App Permissions, but also for Homescreen, System, and Find My Device.  The attached zip contains all the sizes, including a 256x256 generic size (not sure if you still want this size).

Also, I will file a couple of new bugs:

1) Tighten up the drop shadow to match the homescreen app icons
2) Make App Permissions use the new 2.0 default app icon

Peter.

Comment 10

[Peter La]

Hi Aus, I just read your comment.  Assigning to you.

Thanks!!!
Peter

Comment 11

[Peter La]

Attachment: AppPermissionsIcons-Mockup.jpg

This mockup shows the new 4 new icons on the App Permissions page, along with the tigher dropshadow.

Comment 12

[Peter La]

Aus,

Just to explain my Comment 9 - I found that App Permissions in settings was pulling in old icons from 1.4 for Homescreen, System, and was missing an icon for Find My Device, so I've included those 3 other icons.  Hopefully they can all be fixed with this bug.

Thanks again,
Peter

Comment 15

[Aus Lacroix [:aus]]

Hi Peter,

I'm not seeing the new Homescreen, System and Find My Device icons, is it possible that the wrong zip file was attached? The one I have also doesn't have 256x256 icons.

Comment 16

[Peter La]

Attachment: FFOS2AppPermissionsIcons-20140716.zip

Hi Aus,

I'm so sorry, you're right, I attached an old zip file from May by accident!  Here's the correct one.  Sorry for the inconvenience/delay.

Peter

Comment 17

[Aus Lacroix [:aus]]

No worries, thanks Peter! :)

Comment 18

[[e-mail]]

peter I found the same issue as bug 1022506 that the normal icon size might be 84x84 instead of 80x80.

And for those app that only shows in app permission list, maybe 30x30 is sufficient (as system app does)?

https://github.com/mozilla-b2g/gaia/tree/master/apps/system/style/icons

(those are 30/45/60/68)

Comment 19

[Aus Lacroix [:aus]]

I'm going to go ahead and land the icons as they are for 2.0, we can figure out for 2.1 if we really need to optimize and strip out the other sizes if we run into partition space issues. You guys can feel free to open a new bug for this to track your discussion.

Comment 20

[Aus Lacroix [:aus]]

Also, I know for fact that the homescreen will be showing in the task manager for 2.1. Therefor, we *will* need larger icons for it.

Comment 21

[Aus Lacroix [:aus]]

Attachment: Pull Request - Update icons.

Vivien, could you approve these icon updates? Otherwise I will have to flag 4 different people in 3 different timezones for reviews. :(

Comment 22

[Aus Lacroix [:aus]]

Commit (master): https://github.com/mozilla-b2g/gaia/commit/8388e81f0a08fb5b71cb2c37dbc3d3366edab61d

Commit (v2.0): https://github.com/mozilla-b2g/gaia/commit/155b71b5fb3e06d0f04020bc4e869ae180a820c5

Fixed!

Comment 23

[Kevin Grandon :kgrandon]

The sizes of these icons are wrong. We should be using the following sizes: 84, 126, 142, 189, 284

Comment 24

[Aus Lacroix [:aus]]

I'll remove the 80px ones and make 84px ones from 126, should resize all nice. Almost done, in fact.

Comment 25

[Peter La]

Hi Aus,

Please wait until I upload a new set.  The problem is I also found a mistake in the System icon - which has a bite taken out of the gear.  I will upload in a few minutes if you can hold on.

Thanks and sorry!

Comment 26

[Peter La]

Attachment: FFOS2AppPermissionsIcons-20140718.zip

This set of icons fixes the mistake with the @1 size (now 84 instead of 80), and the System icon gear.

Comment 27

[Aus Lacroix [:aus]]

Both master and v2.0 now have the 84x84 icons and have had the 256x256 removed as they are not used anymore.

Comment 28

[Paladin]

Attachment: Verify_image.png

This issue has been verified successfully on Flame 2.0,2.1

See attachment: Verify_image.png
Reproducing rate: 0/5
Flame 2.0 versions:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141130000204
Version         32.0
Flame 2.1 versions:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141130001203
Version         34.0