Closed Bug 1046591 Opened 10 years ago Closed 9 years ago

Swiping down from the URL bar will work as long tap

Categories

(Firefox for Android Graveyard :: Awesomescreen, defect)

Product:
Firefox for Android Graveyard
Component:
Awesomescreen
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox31 affected, firefox32 affected, firefox33 affected, firefox34 affected, firefox35 affected, firefox36 affected, firefox37 affected, firefox38 affected, firefox39 affected, firefox40 affected, firefox41 affected, firefox42 affected, firefox43 affected, firefox44 affected)

Status:
RESOLVED DUPLICATE of bug 1216114
Tracking Flags:
Tracking Status
firefox31 --- affected
firefox32 --- affected
firefox33 --- affected
firefox34 --- affected
firefox35 --- affected
firefox36 --- affected
firefox37 --- affected
firefox38 --- affected
firefox39 --- affected
firefox40 --- affected
firefox41 --- affected
firefox42 --- affected
firefox43 --- affected
firefox44 --- affected

People

(Reporter: cos_flaviu, Assigned: sergej)

Details

Attachments

(1 file)

MozReview Request: Bug 1046591 - Swiping down from the URL bar will work as long tap
40 bytes, text/x-review-board-request
Details 
Environment: 
Device: Asus Transformer Tab (Android 4.2.1);
Build: Nightly 34.0a1 (2014-07-31);

Steps to reproduce:
1. Launch Firefox;
2. Swipe down from the URL bar;

Expected result:
Nothing happens.

Actual result:
Swiping down from the URL bar will work as long tap.
status-firefox35: --- → affected
status-firefox36: --- → affected
status-firefox37: --- → affected
status-firefox38: --- → affected
status-firefox39: --- → affected
status-firefox40: --- → affected
status-firefox41: --- → affected
status-firefox42: --- → affected
status-firefox43: --- → affected
status-firefox44: --- → affected
Bug 1046591 - Swiping down from the URL bar will work as long tap
Attachment #8671459 - Flags: review?(margaret.leibovic)
Not sure who should review this :)
Flags: needinfo?(margaret.leibovic)
Comment on attachment 8671459 [details]
MozReview Request: Bug 1046591 - Swiping down from the URL bar will work as long tap

I think Sebastian would be a better reviewer for this. Redirecting :)
Flags: needinfo?(margaret.leibovic)
Attachment #8671459 - Flags: review?(margaret.leibovic) → review?(s.kaspari)
Hey Sergej, sorry for the review delay! The code looks good but I was wondering whether you looked into why the long press is handled by BrowserToolbar and not just by the url input? There are more issues with the current implementation. For example long pressing the bookmark icon on the toolbar (tablet!) also shows the dialog. Maybe we can fix all that together by letting the url input field handle the long press only.
Assignee: nobody → sergej
Flags: needinfo?(sergej)
Now context menu is attached to toolbar, but not to url. I've simple fixed this bug. If you know that it is safe to move that context menu deeper to url, then I can take a look. Don't want to add regression problems.
Flags: needinfo?(sergej) → needinfo?(s.kaspari)
(In reply to Sergej Kravcenko from comment #5)
> Now context menu is attached to toolbar, but not to url. I've simple fixed
> this bug. If you know that it is safe to move that context menu deeper to
> url, then I can take a look. Don't want to add regression problems.

I can't guarantee that it's going to be safe (Here be dragons!). But if you have time digging into this, that would be very helpful! :)
Flags: needinfo?(s.kaspari)
Comment on attachment 8671459 [details]
MozReview Request: Bug 1046591 - Swiping down from the URL bar will work as long tap

I filed bug 1216114 for trying to fix all those problems by moving the context menu from BrowserToolbar to just the url bar.
Attachment #8671459 - Flags: review?(s.kaspari)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: