1216114 - Context menu should be attached to url input instead of to the whole BrowserToolbar

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

BrowserToolbar has a context menu listener attached[1]. But we actually want the context menu only to be triggered by long pressing the url bar.

The current implementation has multiple problems, for example:
* Swiping down from the toolbar triggers the context menu (Originally tracked by bug 1046591)
* Long pressing the bookmarks icon (tablet) triggers the context menu too

[1] https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/toolbar/BrowserToolbar.java#234-272

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

This also explains bug 1144707.

Comment 3

[Sergej Kravcenko]

Attachment: MozReview Request: Bug 1216114 - Context menu should be attached to url input instead of to the whole BrowserToolbar

Bug 1216114 - Context menu should be attached to url input instead of to the whole BrowserToolbar

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Michael Comella (:mcomella) from comment #2)
> This also explains bug 1144707.

I filed bug 1216212 to remove the hack implemented by bug 1144707.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8675785 [details]
MozReview Request: Bug 1216114 - Context menu should be attached to url input instead of to the whole BrowserToolbar

https://reviewboard.mozilla.org/r/22423/#review20099

Awesome! Thanks Sergej for picking this up so fast after bug 1046591.

Are you interested in picking up the follow-up bug 1216212 Mike filed?

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ffded26b87d5

Comment 7

[Sergej Kravcenko]

Sure, I'll take a look

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/8719182689c1

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8719182689c1

Comment 10

[Teodora Vermesan (:TeoVermesan)]

Swiping down from the URL Bar does not trigger the context menu anymore. Also long tapping the bookmark icon  does not trigger the context menu.
So, verified as fixed using:
Device: Nexus 9 (Android 5.1)
Build: Firefox for Android 44.0a1 (2015-10-22)