Closed Bug 1046885 Opened 7 years ago Closed 7 years ago

Disable installing webapps in guest mode

Categories

(Firefox for Android Graveyard :: Web Apps (PWAs), defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox34 verified)

VERIFIED FIXED
Firefox 34
Tracking Status
firefox34 --- verified

People

(Reporter: wesj, Assigned: wesj)

References

Details

Attachments

(1 file)

You shouldn't be able to install webapps if you're in guest mode.
Yes please, we crash on application launch still (bug 973942).
Attached patch PatchSplinter Review
I wasn't sure the best place to do this. This disables installs in guest mode and provides an error message that the app store can show. It also disables the apps menu item.

I realized I should probably also disable the other menu items that I'm disabling in guest mode, downloads and extensions. That's in here too because I didn't want to upload three patches in three bugs.
Attachment #8471360 - Flags: review?(myk)
Comment on attachment 8471360 [details] [diff] [review]
Patch

Review of attachment 8471360 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/modules/WebappManager.jsm
@@ +90,5 @@
>  
>    _installApk: function(aMessage, aMessageManager) { return Task.spawn((function*() {
> +    if (this.inGuestSession()) {
> +      aMessage.error = Strings.GetStringFromName("webappsDisabledInGuest"),
> +      aMessageManager.sendAsyncMessage("Webapps:Install:Return:KO", aMessage);

This is consistent with the error messages elsewhere in WebappManager.jsm, but I just noticed that it's inconsistent with the ones in Webapps.jsm, which are all underscore-separated codes like "INVALID_MANIFEST_CONTENT_TYPE".  I wonder if we should change these too.
Attachment #8471360 - Flags: review?(myk) → review+
Blocks: 1058149
https://hg.mozilla.org/mozilla-central/rev/60c0fcdb7425
Assignee: nobody → wjohnston
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Status: RESOLVED → VERIFIED
Flags: qe-verify-
OS: Linux → Android
Hardware: x86_64 → ARM
Version: unspecified → Trunk
Depends on: 1059394
Blocks: 1065752
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.