1046885 - Disable installing webapps in guest mode

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect)

Description

[Wesley Johnston (:wesj)]

You shouldn't be able to install webapps if you're in guest mode.

Comment 1

[Aaron Train [:aaronmt]]

Yes please, we crash on application launch still (bug 973942).

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch

I wasn't sure the best place to do this. This disables installs in guest mode and provides an error message that the app store can show. It also disables the apps menu item.

I realized I should probably also disable the other menu items that I'm disabling in guest mode, downloads and extensions. That's in here too because I didn't want to upload three patches in three bugs.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 8471360 [details] [diff] [review]
Patch

Review of attachment 8471360 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/modules/WebappManager.jsm
@@ +90,5 @@
>  
>    _installApk: function(aMessage, aMessageManager) { return Task.spawn((function*() {
> +    if (this.inGuestSession()) {
> +      aMessage.error = Strings.GetStringFromName("webappsDisabledInGuest"),
> +      aMessageManager.sendAsyncMessage("Webapps:Install:Return:KO", aMessage);

This is consistent with the error messages elsewhere in WebappManager.jsm, but I just noticed that it's inconsistent with the ones in Webapps.jsm, which are all underscore-separated codes like "INVALID_MANIFEST_CONTENT_TYPE".  I wonder if we should change these too.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/60c0fcdb7425