1047111 - browser.blockedPopups.reported might not have the correct value

Status: NEW

(Toolkit :: General, defect)

Description

[[e-mail]]

The old browser.pageReport used to recycle the array object. This meant that browser could set browser.pageReport.reported to true when it handled a popup while toolkit would reset browser.pageReport.reported to false when it processed a new popup, but not if there was an update for some other reason.

However the new browser.blockedPopups is a new array object every time. This means that browser.blockedPopups.reported might incorrectly be unset.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

What are the practical effects of this? I have a hard time even following this code. Why does updateBlockedPopups need to be called on pageshow?

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I see. I guess this could cause the page-report-button panel to disappear prematurely.

However, I'm not sure why we need to call updateBlockedPopups from pageshow or pagehide. I just copied what the old code did. I can see that you might want to filter out popups if an iframe navigates or something. But we already have a pagehide handler that clears blockedPopups, so that seems to defeat the purpose of the whole thing.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

[Tracking Requested - why for this release]:

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Tracking because it could be boring for some users but we probably won't block the release for this.

Updating the 31 tracking flags. Since 32 is unaffected, I guess it is the same for 31

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Bill/Neil, I don't think this is serious enough to track this for upcoming releases. If you think otherwise, can you let me know?

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.