1047240 - Default spellchecker doesn't propose correction and do not allow to add work to the custom dict.

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Editing, defect)

Description

[Jean-Yves Perrier [:teoli]]

What did you do?
================
1. I went to a page with spelling errors
2. The standard Firefox spellchecker shows red wavy underline
3. Right-click on one miss-pelled work.

What happened?
==============
Blue contextual menu without spellchecking field

What should have happened?
==========================
Contextual menu with proposal of correct word + Add to dictionary link.

Is there anything else we should know?
======================================
Wavy underline alone are useless.

Comment 1

[Jean-Yves Perrier [:teoli]]

Attachment: Screen Shot 2014-08-01 at 09.24.39.png

Standard menu with needed field

Comment 2

[Jean-Yves Perrier [:teoli]]

Attachment: Screen Shot 2014-08-01 at 09.25.04.png

Menu in MDN.

Comment 3

[Luke Crouch [:groovecoder]]

Uplifting :hoosteeno's comment [1] here:

"We can disable the contextmenu[2], but this will be a global change (it will apply to everyone, not only those using the native spell checker). I don't personally find much value in CKEditor's context menu; does anyone else? 

If nobody else gets much value from it, we can simply add three plugins to the removePlugins config setting as in [2] below."

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1032056#c17
[2] http://stackoverflow.com/a/12216307/185319

Comment 4

[Justin Crawford [:hoosteeno] [:jcrawford]]

I'll just add that the fix proposed in comment 3 [2] disables /all/ ckeditor context menus. In regular text, that doesn't seem like much of a problem since the context menu is basically useless. But in tables and lists, the ckeditor context menu provides important functionality that would otherwise require source editing.

I don't have enough insight into editorial workflows to know whether those table and list functions are valuable. If they're not, we can disable the ckeditor context menu and enable the browser default.

If they are valuable, we can't disable them. But you can use the CTRL or CMD button with a right click to access the browser default context menu.

Comment 5

[Māris Fogels [:mars] (please needinfo)]

:sheppy, will this be fixed by the current work happening on CKEditor?

Comment 6

[Māris Fogels [:mars] (please needinfo)]

This is a follow-up to bug 1031910.

Comment 7

[Florian Scholz (Open Web Docs)]

fwiw, I am using the CTRL key all the time to get the normal context menu. However, the CKEditor context menu for tables is valuable to me, but for the normal text - as said - not so much.

Comment 8

[Florian Scholz (Open Web Docs)]

(In reply to Florian Scholz [:fscholz] (elchi3) from comment #7)
> However, the CKEditor context menu for tables is valuable to me, but for the
> normal text - as said - not so much.

I tried to observe my behavior with the CKEditor context menu and, besides tables, there is a second use case for me: When you hover over links, you are able to quickly get the "Edit link" overlay, which is also handy.

Comment 9

[Eric Shepherd [:sheppy]]

The CKEditor upgrade includes a spell checker that presents possible replacements in the context menu. However, there doesn't seem to be a way to tell it to use anything but English.

I've filed bug 1113109 about adding support for other languages to the spell checker. I've also filed bug 1113112 about adding support for adding words to the custom dictionary.

I'm closing this bug, since the spell check suggestions now work in English. Those new bugs will cover the other improvements.