1047406 - Remove conversation window notifications; implement title changes when displaying feedback form (form currently overflows window)

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

Bug 972992 is implementing the feedback form on desktop.

Currently when hitting the sad face, the bottom of the feedback form is hidden and you have to scroll to show the button. We discussed with Darrin, and came up with the requirements, as described by the user story.

Comment 1

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: Remove notifications in Loop conversation window.

This patch removes the use of the NotificationCollection in the conversation window, and uses window title changes to notify the end user about call state changes.

This is to be considered as a transition until bug 1047410 lands, code has been heavily commented about this.

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8498127 [details] [diff] [review]
Remove notifications in Loop conversation window.

Review of attachment 8498127 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=Standard8

Comment 3

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/7dde79b5e40e

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7dde79b5e40e

Comment 5

[Maire Reavy [:mreavy]]

Hi Pauly -- This is ready to verify.  Thanks!

Comment 6

[Paul Silaghi, QA [:pauly]]

Couple of issues here, not all of them related to this bug:
1. the outgoing call window doesn't display 'call failed' in the title bar, just 'Something went wrong' in the window's layout. 'Call failed' for the incoming call window cannot be tested yet (bug 1076794)
2. the outgoing call window displays the opponent's email address in the title bar while ringing, the incoming call window displays 'conversation request' while ringing. It displays 'conversation request' even after accepting the call
3. no call ended/failed notification for the guest callers (link clickers), just the feedback window
4. a new call won't start if the outgoing call window is opened (showing feedback or retry/cancel)
Please advise what needs to be filed.

Comment 7

[Mark Banner (:standard8)]

(In reply to Paul Silaghi, QA [:pauly] from comment #6)
> Couple of issues here, not all of them related to this bug:
> 1. the outgoing call window doesn't display 'call failed' in the title bar,
> just 'Something went wrong' in the window's layout. 'Call failed' for the
> incoming call window cannot be tested yet (bug 1076794)

So I haven't yet asked explicit UX review on this, but the intention with keeping the title bar as the user's name, was to keep the user aware of who would be called in the event of a retry. If we put the something went wrong in the title bar, then it'd be unclear as to who the window is for. If you want to file a bug to verify the UX here, that's fine.

> 2. the outgoing call window displays the opponent's email address in the
> title bar while ringing, the incoming call window displays 'conversation
> request' while ringing. It displays 'conversation request' even after
> accepting the call

The incoming call window is bug 1020449

> 3. no call ended/failed notification for the guest callers (link clickers),
> just the feedback window

That's correct, "call ended" quietly went away from the UX specs. The "Your conversation has ended" is the right thing to display.

> 4. a new call won't start if the outgoing call window is opened (showing
> feedback or retry/cancel)

That's a side-effect of the busy handling. I think it would be worth filing a bug - we should probably allow a new call when in the feedback state, but not any other.

Comment 8

[Paul Silaghi, QA [:pauly]]

(In reply to Mark Banner (:standard8) from comment #7)
> (In reply to Paul Silaghi, QA [:pauly] from comment #6)
> > Couple of issues here, not all of them related to this bug:
> > 1. the outgoing call window doesn't display 'call failed' in the title bar,
> > just 'Something went wrong' in the window's layout. 'Call failed' for the
> > incoming call window cannot be tested yet (bug 1076794)
> So I haven't yet asked explicit UX review on this, but the intention with
> keeping the title bar as the user's name, was to keep the user aware of who
> would be called in the event of a retry. If we put the something went wrong
> in the title bar, then it'd be unclear as to who the window is for. If you
> want to file a bug to verify the UX here, that's fine.
bug 1079816

> > 3. no call ended/failed notification for the guest callers (link clickers),
> > just the feedback window
> That's correct, "call ended" quietly went away from the UX specs. The "Your
> conversation has ended" is the right thing to display.
I was trying to say that no message of this type is displayed on the link clicker's (guest) side

> > 4. a new call won't start if the outgoing call window is opened (showing
> > feedback or retry/cancel)
> That's a side-effect of the busy handling. I think it would be worth filing
> a bug - we should probably allow a new call when in the feedback state, but
> not any other.
bug 1079811

I'm marking this bug as verified fixed since the existing notifications are removed from the conversation window and 'call ended' is displayed in the title bar. The work continues in bug 1076794 and bug 1079816

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8498127 [details] [diff] [review]
Remove notifications in Loop conversation window.

Approval Request Comment
Part of the staged Loop aurora second uplift set

Comment 10

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4d7e58f67c0a

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8498127 [details] [diff] [review]
Remove notifications in Loop conversation window.

Already landed in aurora, approving for posterity

Comment 12

[Paul Silaghi, QA [:pauly]]

Verified fixed FF 34b1 Win 7