1047410 - Desktop client should display Call Failed if an incoming call fails during set-up

Status: VERIFIED FIXED

(Hello (Loop) :: Client, enhancement, P1)

Comment 1

[Romain Testard [:RT]]

This UX is for outgoing call failures (to contacts).
The UX implementation is already tracked under https://bugzilla.mozilla.org/show_bug.cgi?id=1000186

Or am I misunderstanding this bug?

Comment 2

[Mark Banner (:standard8)]

(In reply to Romain Testard [:RT - on PTO back on August 14th] from comment #1)
> This UX is for outgoing call failures (to contacts).
> The UX implementation is already tracked under
> https://bugzilla.mozilla.org/show_bug.cgi?id=1000186
> 
> Or am I misunderstanding this bug?

We've just been discussing this with Darrin - we need a call failed indication for the hopefully rare cases where the incoming call fails to set-up correctly. Hence, although the mock-up is intended for outgoing, using it (without most of the buttons) for incoming is is also fine.

Comment 3

[Paul Silaghi, QA [:pauly]]

So, does this cover the "Cancel button" and "E-mail link" from https://bugzilla.mozilla.org/show_bug.cgi?id=1000186#c7 ?

Comment 4

[Mark Banner (:standard8)]

(In reply to Paul Silaghi, QA [:pauly] from comment #3)
> So, does this cover the "Cancel button" and "E-mail link" from
> https://bugzilla.mozilla.org/show_bug.cgi?id=1000186#c7 ?

I'm not expecting it to currently, I think lets file new bugs to be safe.

Comment 5

[Maire Reavy [:mreavy]]

Darrin -- Does this require any new strings or would we reuse strings from other views?

Comment 6

[Darrin Henein [:darrin]]

I think the strings in https://people.mozilla.org/~dhenein/labs/loop-mvp-spec/#link-prompt should be fine, unless someone had needinfo'd matej for alternate copy elsewhere.

Comment 7

[Andrei Oprea [mention me on [e-mail]]]

What would the cancel button do in this case?

Comment 8

[Andrei Oprea [mention me on [e-mail]]]

Also would the email button generate a new URL to send?

Comment 9

[Mark Banner (:standard8)]

Hmm, this is part of the desktop direct calling case. We can't do this until we have the start of direct calling on desktop.

Comment 10

[Mark Banner (:standard8)]

(In reply to Mark Banner (:standard8) from comment #9)
> Hmm, this is part of the desktop direct calling case. We can't do this until
> we have the start of direct calling on desktop.

So having another look at the bugs, it is actually a bit unclear. I am therefore going to make the decision that this bug is for implementing the view. Just display the appropriate generic failure text.

I'll file new bugs to cover adding the buttons later.

Comment 12

[u279076]

Is there a way to simulate a call failure so this can be tested?

Comment 13

[Maire Reavy [:mreavy]]

I just talked to Darrin and given that this is only going to happen in the case where the Desktop user is called back, it makes sense to display "Something went wrong" (instead of "Call Failed") -- and to not show the "Retry" or "Email" buttons.  At most we'd show the "cancel" button (if that didn't look odd).

Comment 14

[Maire Reavy [:mreavy]]

I think this bug should include adding the "cancel" button (again, assuming the "cancel" button by itself doesn't look odd).

Comment 15

[Mark Banner (:standard8)]

Attachment: Desktop client should display Call Failed if an incoming call fails during set-up

WIP patch that is almost ready, just needs tests writing.

Comment 16

[Mark Banner (:standard8)]

Attachment: Desktop client should display Call Failed if an incoming call fails during set-up

This fixes the tests as well.

Although we could try and share the view with the flux implementation of the call failed for outgoing calls, this seems a bit difficult at the moment - they are based on different ideas, and the outgoing one is tied to flux. Hence I'm thinking we should leave sharing the view until we fluxify the incoming call code.

The best way to test this at the moment is to start an incoming call from a url, but not accept audio/video media on the caller's side after the call is accepted. Then just let it time out.

Comment 17

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Comment on attachment 8511028 [details] [diff] [review]
Desktop client should display Call Failed if an incoming call fails during set-up

Review of attachment 8511028 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=me with the nit addressed.

::: browser/components/loop/content/js/conversation.jsx
@@ +181,5 @@
>    /**
> +   * Incoming Call failed view. Displayed when a call fails.
> +   *
> +   * XXX Based on CallFailedView, but built specially until we flux-ify the
> +   * incoming call views.

Nit: Please add the bug number as a reference.

Comment 18

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/705cec97abf1

For test steps, see comment 16.

Comment 19

[Maire Reavy [:mreavy]]

Comment on attachment 8511028 [details] [diff] [review]
Desktop client should display Call Failed if an incoming call fails during set-up

Approval Request Comment
[Feature/regressing bug #]:Displaying call failed to user
[User impact if declined]:  the user would see a feedback form for a call that was not successfully completed
[Describe test coverage new/current, TBPL]: unit tests, manually verified
[Risks and why]: No risk outside of Hello; low risk to Hello; without this, users who couldn't connect would see a feedback form for a call that didn't happen -- which would be confusing and could skew user metrics (which product is depending on)
[String/UUID change made/needed]: No strings

Comment 20

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/705cec97abf1

Comment 21

[u279076]

(In reply to Wes Kocher (:KWierso) from comment #20)
> https://hg.mozilla.org/mozilla-central/rev/705cec97abf1

Paul, can you please confirm this is fixed in the latest Nightly?

Comment 22

[Randell Jesup [:jesup] (needinfo me)]

Tested on Nightly 10/25; looks good.

Comment 23

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8511028 [details] [diff] [review]
Desktop client should display Call Failed if an incoming call fails during set-up

Aurora+

The plan is to verify on Aurora on Sunday before uplift for beta4.

Comment 24

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ad29598131d4

Comment 25

[Randell Jesup [:jesup] (needinfo me)]

Verified on Aurora Nightly 10/26 Linux

Comment 26

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8511028 [details] [diff] [review]
Desktop client should display Call Failed if an incoming call fails during set-up

Beta+

Comment 27

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-beta/rev/d2ef2bdc90bb

Comment 28

[Paul Silaghi, QA [:pauly]]

(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #13)
> I just talked to Darrin and given that this is only going to happen in the
> case where the Desktop user is called back, it makes sense to display
> "Something went wrong" (instead of "Call Failed") -- and to not show the
> "Retry" or "Email" buttons.  At most we'd show the "cancel" button (if that
> didn't look odd).
"Something went wrong" and "Cancel" button displayed for guest users.
Verified fixed FF 34b4.