1047520 - Canvas debugger doesn't work in chrome context

Status: RESOLVED FIXED

(DevTools Graveyard :: Canvas Debugger, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

And yet, I can enable it in the options panel, hit reload, and then the browser is broken.

Not really surprised, but I really wish I had it right now :(

Comment 1

[Victor Porof [:vporof][:vp]]

Unlikely to work at least until bug 985109 is fixed.

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Would be nice to make it so it can't be enabled in the browser toolbox in the meantime. I think we can do this with the targetSupported stuff in the framework, but I've never really been that familiar with that part of our code base.

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Disable the Canvas Debugger in the Browser Toolbox

Disabling the Canvas Debugger is easy. I don't know what prevents it from working in chrome code, so is there another bug for that, or shall we leave this one open?

Comment 4

[Victor Porof [:vporof][:vp]]

Comment on attachment 8478267 [details] [diff] [review]
Disable the Canvas Debugger in the Browser Toolbox

Review of attachment 8478267 [details] [diff] [review]:
-----------------------------------------------------------------

Bug 981748.

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/ba1d285f2dde

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ba1d285f2dde