1047607 - Take advantage of nsIURIFixup improvements for faster location bar searches

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[:Margaret Leibovic]

Bug 693808 improved location bar searches for desktop. We should take advantage of these platform changes to do the same thing!

IIRC, we have some of our own custom logic in place to try band-aid over some of these problems, but it seems like we could have a real solution now.

http://msujaws.wordpress.com/2014/08/01/faster-and-snappier-searches-now-in-firefox-aurora/

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Remove URL search hacks

Since these hacks were a workaround for bug 693808, we can remove them now that bug 693808 has landed. I can confirm that number queries still work (and searches in general are faster, which is nice).

Comment 2

[:Margaret Leibovic]

Comment on attachment 8467169 [details] [diff] [review]
Remove URL search hacks

Review of attachment 8467169 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

Comment 3

[:Margaret Leibovic]

Should we file a follow-up bug to add a notification asking users if they actually do want to try navigating to a locally hosted site, similar to what desktop has now? The unfortunate thing is that we only have doorhangers, not notification bars, so this would be more disruptive to users. 

Perhaps we should just add some developer setting for that?

Comment 4

[Brian Nicholson (:bnicholson)]

(In reply to :Margaret Leibovic from comment #3)
> Should we file a follow-up bug to add a notification asking users if they
> actually do want to try navigating to a locally hosted site, similar to what
> desktop has now? The unfortunate thing is that we only have doorhangers, not
> notification bars, so this would be more disruptive to users. 

It's also more disruptive for us since we have a single input box that merges the location bar and search bar, so it would appear more frequently on mobile. Not sure how much we care about having this, but filed bug 1048533 to track it.

Comment 5

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/fx-team/rev/3c1d7f138339

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3c1d7f138339

Comment 7

[:Margaret Leibovic]

Bug 693808 was uplifted to 33. Should we uplift this?

Comment 8

[Brian Nicholson (:bnicholson)]

(In reply to :Margaret Leibovic from comment #7)
> Bug 693808 was uplifted to 33. Should we uplift this?

Don't think there's any reason to since there's no user-facing change. Bug 854305 and bug 693808 essentially accomplish the same thing; they're redundant, but not conflicting.